Re: [PATCH] automation: Add missing and drop obsoleted aliases from containerize

[Michal Orzel <michal.orzel@xxxxxxx>]

On 03/03/2023 13:21, Michal Orzel wrote:
> 
> 
> On 03/03/2023 13:13, Andrew Cooper wrote:
>>
>>
>> On 03/03/2023 12:09 pm, Michal Orzel wrote:
>>>
>>> On 03/03/2023 12:59, Andrew Cooper wrote:
>>>>
>>>> On 01/03/2023 9:06 am, Michal Orzel wrote:
>>>>> Add missing aliases for:
>>>>>  - debian:unstable-cppcheck
>>>>>  - debian:unstable-arm64v8-arm32-gcc
>>>>>  - ubuntu:bionic
>>>>>
>>>>> Remove aliases for no longer used containers:
>>>>>  - centos:7.2
>>>>>  - debian:unstable-arm32-gcc
>>>>>
>>>>> Modify docs to refer to CentOS 7 instead of 7.2 not to create confusion.
>>>>>
>>>>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>>>>> ---
>>>>> Open questions related to the CI cleanup (@Andrew, @Anthony):
>>>>>  - Why do we keep suse:sles11sp4 dockerfile?
>>>>>  - Why do we keep jessie dockefiles?
>>>> Because we don't yet have a process for retirement of such things.
>>>>
>>>> Right now, all branches other than staging are using the jessie
>>>> containers.  While it's still in use on any branch, we need some way to
>>>> rebuild the container (potentially with modifications - see the recent
>>>> HTTPS fun), and standard practice is "patches into staging".
>>>>
>>>> An alternative could be to patch into the most recent staging branch
>>>> containing the dockerfile.
>>>>
>>>>
>>>> sles11sp4 is more complicated.  We specifically tried to get a SLES
>>>> container working, but it was always in a weird state (only @suse people
>>>> could rebuild the container).  We did eventually replace it with
>>>> OpenSUSE containers, but I can't currently locate any evidence in the
>>>> gitlab yml that we wired sles11sp4 up.   Which is confusing because I
>>>> swear we did have it running at some point in the past...
>>> Ok, thanks for answering. Stefano wanted me to remove these unused 
>>> dockefiles.
>>> Are you ok with that or only to remove sles for now?
>>
>> So https://gitlab.com/xen-project/xen/-/pipelines/791687536 is the
>> latest pipeline on Xen 4.14  (yeah, that's a concerning amount of
>> red...) but I don't see any SLES runs and I do see the OpenSUSE runs.
>>
>> So I think we can safely drop the sles dockerfile, and drop the tags.
> Ok. FWICS, there is only a dockefile for sles. No jobs, no tags, so just
> dockerfile to remove.
Now I realized that by tags you meant removing it from registry as well.

> 
>>
>> But I'd like to keep jessie around until we have figured out what our
>> deprecation process is.
> I'm ok with that and I think that your alternative approach is a good way to 
> go.
> That said, I think we could still remove jessie aliases from containerize, 
> while
> keeping the dockerfiles for now until deprecation process is ready.
+ I think we can remove jessie aliases together with dockerfiles once process 
is ready.

> 
> ~Michal
> 

~Michal