Xen project Mailing List

Re: [XEN PATCH backport for-4.15] tools: Drop gettext as a build dependency

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>

Date: Mon, 6 Mar 2023 08:38:53 +0100

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSVXXmIaRInjRD19BeEx3RH4W72+sp6hVa1K0cRrOmA=; b=PUj905I6RZPYvGyAyUKdqNs/WUIogifxgbuVjhTT+6lbrDPYQpQc4PRKqyeZZhHag64z55Vtv9ZWX8FxpcEf/bg3HoyA3o9ag0LioE+esVF/Cg1ecgS7wrRFkzSFoYUwfu2qdWztX2cAJQZx1ylO2RQtTwUjAb645wrRb+ja90Pm/XOGET7twTpmSRiZ4EXzlB16xPfhK2aM3wixTyeEqb+AsTqsXkONlsiiFneXJFN0A45/ZpxbQEcdRVF2FgLHQtgIEc0IPQmtq9eD5dxl8AGixuvEz3NPr/NIVAGAPqWBhZnA6c5Rxf6cZAcokRzZBzNHBWLm8t3fWoXzA7QA9g==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7tGXTvWDhACkUpE68DUKlhyJ26ilkhMMJSHWwnIELrPp6xnGD+hJDPwiRj1P2UShYGjSFfrvpGw9TBigRAclG74oHQ4lLdystp1szHmlyt7ciNEjzuykJZ+lg+kV3fkIDaDRLfO1kreQg+A6PYykPzFJv6rvVatX6OXV9UOWdjDNSFEwlhd225RbPE5JdE+8FezwWkDSwFmyUm7LqDZA3NHarLNEy33kvD+f3dXfmj19VcLhwcLhnWoNlBW4+VpYFj8nAV5RoRy/xbd/0TwXwMWuFGukZQmLJ6yG5H0zF3aQMwRLg1zn4261ySHEKj4ORFCesbpVUVcodDwGz7Xbg==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;

Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx

Delivery-date: Mon, 06 Mar 2023 07:39:04 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.03.2023 16:27, Andrew Cooper wrote: > On 03/03/2023 2:55 pm, Anthony PERARD wrote: >> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> >> >> It has not been a dependency since at least 4.13. Remove its mandatory check >> from ./configure. >> >> Annotate the dependency in the CI dockerfiles, and drop them from CirrusCI >> and >> TravisCI. >> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> >> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> >> (cherry picked from commit e21a6a4f966a7e91cb0bb014dbe15d15cc0502ad) >> --- >> >> Notes: >> As we dropped "gettext" from many containers, build on staging-4.15 >> starts to fail due to unmet dependency. But that dependency isn't needed, >> but configure hasn't been updated. >> >> pipeline with many fail due to missing gettext: >> https://gitlab.com/xen-project/xen/-/pipelines/793302203 >> >> pipeline with that patch backported: >> >> https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/794335026 >> still several build failure, but less, and not due to configure step >> failing. >> >> Commit can be cherry-picked cleanly to staging-4.15. >> >> That commit would be needed as well on staging-4.14, but it doesn't >> apply cleanly due to change in configure, and missing dockerfiles. > > Urgh - I'm sorry about this. I'd completely forgotten about this mess. > > We do need to get CI working reliably, even on all old branches, so we > do need to backport this too. > > But looking at the diffstat below, I think we also want to backport > other things too (the change removing Travis), and I'm not sure we want > to re-add the dockerfile comment seeing as we've already dropped it and > rebuilt them all, and this patch is the one that stops it being mandatory. > > That would simplify this patch a lot, and make it applicable to 4.14 > too, I think. > > Jan - are you happy for Anthony and I to just go free reign on the older > branches until we've got testing into a working state? Sure, as long as it doesn't get really unwieldy. Jan

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.