[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH backport for-4.15] tools: Drop gettext as a build dependency
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 3 Mar 2023 15:27:56 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wi9FK1PD7eCidk9Ig71Sj5Wn3Jb8t3uNB0UsTz9k8sI=; b=mDyvI8h52BvESSVW+y4p/kUUd66Qv29dS26DOFX2nTIlaSs8eBPiD2+99rofdvpf13om8feoIqXtsLSqP2uABGDa5psbr1xspt7C0TIY61zrMpjJ6JdbX88mntCtJUJFrT/cdu0Yxx5dFRJqOLc+78Tkb222upi/cUGMohkt6VwELx9faTo3MIEEFxCQ07OcC1SNF2Gr5gHiorGnDJ0yu694o7PEre3JZ4cUyRHL1RHQAFJYeaa8nyNePRrIJ8UUtKSHJmd6mBHgoBaLq1anfuesmpbSnSh+iNw+ehN7YX9wCmcByC2/snm0axGN57xsjOUDXubqa+KhfMnmRVADSg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2mfUUNxSHdfbBvWuli7YjohpFCcfDHr1DBqSRMtlUuG2yqUaiLUBWnqgGDZRQKZGAhuYA9GNmQCr+ciybif1nqpFHPejB0bDj6XteeK9uR/szlH913n0m0gaJWFt3XG4UyKBJ7tm11TicTdpaDcKDCdJEvnvgJDPJtrqQt4+KNtDnECrKBm+4N9eMXgEWpqNIi6XXWFhYwGTWm+8Rf6NcKbz8+AZkpB2zXf4VV1OlkvJW5gOiFNk3mexCpbd0LZYAwi1dTAU2x4/A032S1XsD5/gScSownSfSamyaiONyINRSPoSTd1gP6j+u0hA4sTBeXeMXdMNZqrPBZD8SOlKg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Fri, 03 Mar 2023 15:28:29 +0000
- Ironport-data: A9a23:TAFAsq7KS66SnYqwNZywrQxRtCbGchMFZxGqfqrLsTDasY5as4F+v mMfUWyBOqmJNmT8fdhwPt/i9UNSupLXn4RkQVBpqX8wHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPasT5weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0 f8/cDQScB+6iuO8memjWuxlpZ0qI5y+VG8fkikIITDxK98DGMmGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEoojumF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNCS+bhpqc76LGV7lA2Nxo0VHSfmNeSjBejWPVfM l4r2yV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc0TzE30 l6Cn/vyGCdi9raSTBqgGqy8qDqzPW0fKz8EbCpdFA8duYC98cc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm
- Ironport-hdrordr: A9a23:SZQqeaCLIWOuRf3lHemo55DYdb4zR+YMi2TDgXoBLSC9E/b5qy nApp8mPHPP4gr5O0tApTnjAsa9qCjnhPtICOAqVN+ftW/d1VdAR7sN0WKN+VHd84KVzJ876U /NGZIOa+EZrDJB/KTH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/03/2023 2:55 pm, Anthony PERARD wrote:
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> It has not been a dependency since at least 4.13. Remove its mandatory check
> from ./configure.
>
> Annotate the dependency in the CI dockerfiles, and drop them from CirrusCI and
> TravisCI.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> (cherry picked from commit e21a6a4f966a7e91cb0bb014dbe15d15cc0502ad)
> ---
>
> Notes:
> As we dropped "gettext" from many containers, build on staging-4.15
> starts to fail due to unmet dependency. But that dependency isn't needed,
> but configure hasn't been updated.
>
> pipeline with many fail due to missing gettext:
> https://gitlab.com/xen-project/xen/-/pipelines/793302203
>
> pipeline with that patch backported:
>
> https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/794335026
> still several build failure, but less, and not due to configure step
> failing.
>
> Commit can be cherry-picked cleanly to staging-4.15.
>
> That commit would be needed as well on staging-4.14, but it doesn't
> apply cleanly due to change in configure, and missing dockerfiles.
Urgh - I'm sorry about this. I'd completely forgotten about this mess.
We do need to get CI working reliably, even on all old branches, so we
do need to backport this too.
But looking at the diffstat below, I think we also want to backport
other things too (the change removing Travis), and I'm not sure we want
to re-add the dockerfile comment seeing as we've already dropped it and
rebuilt them all, and this patch is the one that stops it being mandatory.
That would simplify this patch a lot, and make it applicable to 4.14
too, I think.
Jan - are you happy for Anthony and I to just go free reign on the older
branches until we've got testing into a working state?
~Andrew
|
