[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] automation: add Ubuntu container for Xilinx hardware tests
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 6 Mar 2023 09:39:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CsQHG1nbJ+u+pOp0g3LeW7mMIkmRmXER6TX8lSb5M64=; b=fwmck9X2HQw48Ad3Na4ui1p7nmvaQwBBCyHmCMW4Oi89m0b8aQN8r6n+FupWQPfShbiUr8IkszzLJxC+nIWmPHlnmThaMruaaYc6F3yr7ExBq1RXwwbVl3QJ8+x/utf+v6LmglkY2XyvWrMmcfpUMb4ZIimSN6gdyYoFkQMpWzhVc04CZJhA9Yhq5Wi5qa2mxBOFf18mvnP4YniIVDiQYFRvGIYBgxhNUh+4XZRu6yxjyNo5ew2UYsW52mE2eQinBR0PIvES4g/jQRydcZSMfwGgx6RhVqX3PU7pB05hXLbi0EyawhO5CuJlgzVAgMpNOJghcJQujWEWJYXgbFLmfA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfT4RFomdq79w+BAu/TGE8r3HnvhG6Duy9BcIqpYEr3AsNkXK8XDbXKHjWokhWKO6X0ZWtv7k40bpAzsuCGjNPbx2IrH6xDJDLVoZ+Zdpc6WkpbDPdxsRcxf9eQ3LUnsodtuI7l2VFYMy1lIBzUF+O+5CbrLMV6rPdN0TN8oxl3jTQBvf1gXYmM8/2UhkARjpnED+QvSMgT4wdmF6CPpoulx5A1Zz3Cu4dx8LzZuaYU89IXPPG0BvvKsSh6/yNWjujUTomnepFR+K+oI0KRs++rKG0UylkBIcZouuNAH5jjcWcL1dDN+u4asW4p2MLQLLiZASCH3rdkgZ5RLbc+YvA==
- Cc: <cardoe@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>
- Delivery-date: Mon, 06 Mar 2023 08:39:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Stefano,
On 04/03/2023 00:57, Stefano Stabellini wrote:
>
>
> From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>
> This container is only run on the controller PC (x86) to trigger the
> test on a connected Xilinx ZCU102 physical board.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> ---
> .../build/ubuntu/xenial-xilinx.dockerfile | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 automation/build/ubuntu/xenial-xilinx.dockerfile
>
> diff --git a/automation/build/ubuntu/xenial-xilinx.dockerfile
> b/automation/build/ubuntu/xenial-xilinx.dockerfile
> new file mode 100644
> index 0000000000..7e4f5d6605
> --- /dev/null
> +++ b/automation/build/ubuntu/xenial-xilinx.dockerfile
> @@ -0,0 +1,25 @@
> +FROM ubuntu:16.04
> +LABEL maintainer.name="The Xen Project " \
> + maintainer.email="xen-devel@xxxxxxxxxxxxxxxxxxxx"
> +
> +ENV DEBIAN_FRONTEND=noninteractive
> +ENV USER root
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +# build depends
This comment is a bit misleading given the usage of this container.
Something like "board bringup depends" would be better and it would make clear
why we have this container.
Apart from that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
