[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

  • To: Matias Ezequiel Vara Larsen <matiasevara@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Mar 2023 11:12:00 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HJPnfFe8idBUNYlVhDXOIMLAPqhrMoUJbXW8Se90YAA=; b=SnegFLsSL/WPOwRiClW+9iHLzyi/EhGdVfb7vYfVQJ8O7tZldTGjxCeE5ZfufFsyULiOWD11jmkd8ONESmvZv3SWyciWITBPiKgQLlH9vW+1Mg5H3AyqyGSsLeBrTzCKSqmCAy3ZN2jipELbP0bMUOJR7koXOhwsi9wenNR4OIwmkPZOPTo0PABwfDnpMFSTplhn2ItCZ82l+kveqerpzU8pjxlEbTu9zrNZQGNgyer4jNq+Q7dszNm8uIqA1iVokCArGT+f2FDAQYjvfSUy24WA+BMMy/X/KIxe4Hzu686aCx7z4hlUKrefcH41Sw76dyGAJu8p64zfncKcc2wMFA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYkYyR8XazbhX7IFIMs3uEs24jSxL+q2t6L+LtFF5GYc0JMG6drkK+4Vbuif/rgfPjXWtGLJHS8l2rhDkfyISUtbIULvW421NyzOJRvbFBRwigVhBx1+sFeAVXJ++9qw0YjmgwIrMLh9vkgBraMbEMvHTBtMmgMlu4fUP1iKnJfWnQz2vUm66PKCXrZgtuIEtegjkO/wnwzFA2OhXlKILqEAZRdnm3MxXulw82frf88iDwudhScrpqD5KriAPJ6KMxKuj0zozvzwQoA7otJGge69HKV8dzSJPHHj3F8KA0Ec7/dmEXVHzhbp1NGIoVsN+BwY3oYOlqXmdPdZwiINhA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Matias Ezequiel Vara Larsen <matias.vara@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 07 Mar 2023 10:12:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.03.2023 15:23, Matias Ezequiel Vara Larsen wrote:
> Regarding your email, I have the following comments:
> - I still do not know how to choose the value of cacheline_size. I understand
> this value shall be between the actual cacheline_size and PAGE_SIZE. A value
> that could match most architectures could be 256 bytes.

This isn't a concern anymore when offset and stride are stored in the
header. It was a concern when trying to come up with a layout where
these value were to be inferred (or known a priori).

> - Xen shall use the "stats_active" field to indicate what it is producing. In
>   this field, reserved bits shall be 0. This shall allow us to agree on the
> layout even when producer and consumer are compiled with different headers.

I wonder how well such a bitfield is going to scale. It provides for
only 32 (maybe 64) counters. Of course this may seem a lot right now,
but you never know how quickly something like this can grow. Plus
with ...

> - In the vcpu_stats structure, new fields can only ever be appended.

... this rule the only ambiguity that could arise to consumers when
no active flags existed would be that they can't tell "event never
occurred" from "hypervisor doesn't know about this anymore".




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.