Re: [PATCH] tools/tests: remove vhpet tests

[Juergen Gross <jgross@xxxxxxxx>]

On 07.03.23 11:02, Jan Beulich wrote:
> On 06.03.2023 17:29, Juergen Gross wrote:
> > tools/tests/vhpet tests don't build since ages (at least since 4.10)
> > and they can't be activated from outside of tools/tests/vhpet.
> This isn't exactly true - see the run-tests-% goal in the top level
> Makefile.
Ah, I missed that one.

> > Remove them as they seem to be irrelevant.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> > Andrew seems to remember that Roger wanted to keep those tests, but
> > this information might be stale or based on false assumptions.
> > So this patch should only go in with Roger's Ack.
> Having tried a little I can see that it's going to be quite a bit of
> work to get the thing to at least build again. In fact it looks as
> if it, having been introduced in 4.5, may already not have built
> successfully anymore by the time 4.5 was released: hpet_init()
> takes a struct domain *, but is passed &vcpu0 (matching what I can
> see in 4.4); I've noticed this while trying to figure out from where
> it got a declaration of the function in the first place.
>
> Nevertheless the test once served a purpose, so it may be worth
> making it work again. So yes, to decide which direction to move we
> will want Roger's opinion.
Yes, I agree. The main reason to write this patch was to come to a
decision what to do with the test: discard it or repair it.

> Whether just building it by default is useful I'm not entirely
> certain. What I'd consider more useful is if tests like this were
> _run_ in the course of routine automated testing.
In which case it would need to built at least by this test step.

I agree this would be a sensible thing to do.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature