[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/tests: remove vhpet tests
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 7 Mar 2023 11:02:25 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PGNNqG66crN0xbi23jiFRqg+lWAEfHlfb9vTyg4VGjM=; b=FCCCJ0/IkSap9ULRpEaphA5zVVMMPpHhlLPDn1Pnvjq5o6lMY+v56COUbxjOuLRFyexkSrFowi2cvqsAZPnaSRIaCgL537z0Qr6MvT6nbRQJAKhI7p78kLbSBnNWr6OfgjEZJWMmKckyAlmzFiYrUFHiFq0soehW6InnKAZzImG5mRPM9WKa2m7OBxRwI/yoNEpzaN7wapFhsuSpZNITAiJZ0/KM6PYd1FncPBUW9ZeGa2E6BqqD23ZUu9vZKAu5YTk3pYNMqltIK7jryXZIUCbxopvVjIwg4QmcdklRLCLchlfCld4Je+2GpI/cDpOFdS8wAKc80EcZqjzHsHnaHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bCK+l0V77pzSDkzGN0N6QKmNZRWLyesDN9Ge9f9abJCT0Vhi0jWj3mZGDS559Exs9SQOZlasUgEFmM+ZBon4PG/NbNOhCQ3OizNT0ESlmazK/XSxyyEzAxyZXD8D0tcfBV4xND8+PUYsrDMjwRpbxxOlk6JZgN2aaOlkRYJa3o9wMhquzVlwakym1vK7vOANqAkSr1ojq5fqDGUma3DrjhWRj6HzqdJol1AgQpVdJMOnGW2Uo6Uzf89YI+5L+jP4JB/kFAt6dUuCLgtqf5+f2xFB9Ymt4xxqD+/JZkd5lOGk0V1OFfv85KjehzAhf8UbiUFMh4mzgeQ0UMyNeFNQjA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 07 Mar 2023 10:02:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.03.2023 17:29, Juergen Gross wrote:
> tools/tests/vhpet tests don't build since ages (at least since 4.10)
> and they can't be activated from outside of tools/tests/vhpet.
This isn't exactly true - see the run-tests-% goal in the top level
Makefile.
> Remove them as they seem to be irrelevant.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Andrew seems to remember that Roger wanted to keep those tests, but
> this information might be stale or based on false assumptions.
> So this patch should only go in with Roger's Ack.
Having tried a little I can see that it's going to be quite a bit of
work to get the thing to at least build again. In fact it looks as
if it, having been introduced in 4.5, may already not have built
successfully anymore by the time 4.5 was released: hpet_init()
takes a struct domain *, but is passed &vcpu0 (matching what I can
see in 4.4); I've noticed this while trying to figure out from where
it got a declaration of the function in the first place.
Nevertheless the test once served a purpose, so it may be worth
making it work again. So yes, to decide which direction to move we
will want Roger's opinion.
Whether just building it by default is useful I'm not entirely
certain. What I'd consider more useful is if tests like this were
_run_ in the course of routine automated testing.
Jan
|
