[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC XEN PATCH 3/6] x86/pvh: shouldn't check pirq flag when map pirq in PVH


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Anthony PERARD" <anthony.perard@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Huang Rui <ray.huang@xxxxxxx>
  • Date: Sun, 12 Mar 2023 15:54:52 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MqKEnNbvS9HCCnWGJMjgGluFe8YkMoLVY+wYZUwY7qc=; b=bddKS3TL/Uh7aL49Om9fHR4SkJWUdHk+zXq2qqcdp2fdKjt3ME3JGjg/XIAqEgkWllKbbMyAFetD1ZoArZAuGlPzdGOnvyzSINvW9CfEwz3e1aS3xx0n36AwdJ2H4gxwVsAZzzt08C1eggLr8K7CkG6WM8CA5oIDBY5l2hkRayuECBUJye6WHakHnanvy2O+yGhgsaSSsMlj2kMMquPIxvOM9RX/ZT+RudVsfF+uYQPXaPxfaXl5P7vLPod0bNIBXdcgh2fd9AyrExLsOUJ64n3wzfnmHtzLDv9YaIQGMGGZN/Yq9d9qy26fso/vQbriOAxDrtntQ0Mv+w5PF2lX7Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nafOpKlcIRTyg23HgmNgeQkBMxcgPqyA+mEVMtwaTireY2ua1u8PC6QLPlmlBuMGi6VmhQ7RehMi+u2Qe43Pip41ifwt0J5Zojp/glznLBpxoahxYRm0vXyWgKi44gD1H2Tn0FqFN34r0C4qZl1F85kTp2b8eJvmp2y0j1KYWGm6bY69otz2NMFUQo6RggA4kchCeqRA7+GUQ/uMJmP8GvLpM9N4NMXUdz02akiZPA+bLePk/oxVvWiLAt6NGih4d3nQqeUc1KmqPtmDAy1HUaEiyk5/+QKYOZ7Xc3ECDe9xrGTN07kfqN5PH62qIDrEQLDT+QJ+IpiLd/iLQaoaSw==
  • Cc: Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, "Stewart Hildebrand" <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Huang Rui <ray.huang@xxxxxxx>
  • Delivery-date: Sun, 12 Mar 2023 07:55:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Chen Jiqian <Jiqian.Chen@xxxxxxx>

PVH is also hvm type domain, but PVH hasn't X86_EMU_USE_PIRQ
flag. So, when dom0 is PVH and call PHYSDEVOP_map_pirq, it
will fail at check has_pirq();

Signed-off-by: Chen Jiqian <Jiqian.Chen@xxxxxxx>
Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
---
 xen/arch/x86/hvm/hypercall.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 405d0a95af..16a2f5c0b3 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -89,8 +89,6 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     case PHYSDEVOP_eoi:
     case PHYSDEVOP_irq_status_query:
     case PHYSDEVOP_get_free_pirq:
-        if ( !has_pirq(currd) )
-            return -ENOSYS;
         break;
 
     case PHYSDEVOP_pci_mmcfg_reserved:
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.