[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH 1/6] x86/pvh: report ACPI VFCT table to dom0 if present
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Huang Rui <ray.huang@xxxxxxx>
- Date: Tue, 21 Mar 2023 14:26:39 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gy9MYKsv2ZV7QNyvLDQHuWHSm9KeQXfhJouOZGc4auQ=; b=lWqkWg0c3tieyuknImN9CAw0kiSxQ5gQzo9aF4Y9ecyniokm/RrKX2Ws9Y1LX/zS/m+ofUTxiSByxFL2jmaJuWUUDWGcLy0LD7G7Lo2nBdezzmWOpW8c0Bfe9J6V36d2j1NeD9asAFRTcTeKOzmK+GWuUwJAS7m7E2vr8KuU8do9C6FlfHdKDImEzsZ27yOwxWfvFOPFaqT35Gg4X9LE0RQGzrVDFU1LW1C5DHvfvVICbDuajbslmnR/14JmWW1hScbHctUk3VwJGlQS7lRozbqwLdmLvFnroq8qDRsCHRpSFUHdpepdSJuvBB1Eocguh2j9jd4uPFzPA0K9TfdKxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijX4iDruhMtzse4irA9xX850/whBeNAwRKgo2Kbw1r5IbUXYNgVW/2Nhitz8aIWLgKyJvQHXxtSA0XtyM0XVYLnKbNzoVyKlC3WNLvPBJdAVjQSbLr40jxh6exQy9PpjSJ6/+px2Tx6nZ9Zxs+TWz8IR27SRc9Gbav4THRGC9YMRRX6vaMbSNQlohuUaw7l+Y7vmt7rADZ13ZaQimjUBjTqS6Q/SDgPOmBxt81lIC4XoF8J+CUYDLWwUN05Rys8h/rDHvtw75PQiFGaY6P3l5oLgbMPQZPRVY0BpWOUP9+FVl4DJDQF4lTg4ButiMrckND59i5dUte5rlwmXw0Ndpg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 21 Mar 2023 06:27:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 13, 2023 at 08:27:02PM +0800, Andrew Cooper wrote:
> On 13/03/2023 12:21 pm, Roger Pau Monné wrote:
> > On Mon, Mar 13, 2023 at 11:55:56AM +0000, Andrew Cooper wrote:
> >> On 12/03/2023 7:54 am, Huang Rui wrote:
> >>> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> >>>
> >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image
> >>> from the firmware instead of doing it on the PCI ROM on the physical
> >>> device.
> >>>
> >>> As such, this needs to be available for PVH dom0 to access, or else
> >>> the GPU won't work.
> >>>
> >>> Reported-by: Huang Rui <ray.huang@xxxxxxx>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >>> Acked-and-Tested-by: Huang Rui <ray.huang@xxxxxxx>
> >>> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
> >>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
> >> Huh... Despite the release ack, this didn't get committed for 4.17.
> > There was a pending query from Jan as to where was this table
> > signature documented or at least registered, as it's not in the ACPI
> > spec or any related files.
> >
> > I don't oppose to the change, as it's already used by Linux, so I
> > think it's impossible for the table signature to be reused, even if
> > not properly documented (it would cause havoc).
> >
> > It's however not ideal to set this kind of precedents.
>
> It's not great, but this exists in real systems, for several generations
> it seems.
>
> Making things work for users trumps any idealistic beliefs about
> firmware actually conforming to spec.
>
Thanks Andrew for understanding! These tables have been there for more than
10+ years on all AMD GPU platforms.
Thanks,
Ray
|
