[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH 1/6] x86/pvh: report ACPI VFCT table to dom0 if present
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 13 Mar 2023 12:27:02 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TII/Ubu+t4CsnA6FCYs5Sl8c453IDpuoZ21wnpi9bVw=; b=fi30N3DS12Aa7f491ZsbtDtALL7phvPARIZuQRTqUK+9XT1rE3mEID0mIXsZysztDksxTUrlZYFhS9kM1tWuwxdG21dryXpziXfsY6L0SHnuqnMBe4e12nj0E/xmCc4tn5ZM5S6sYzgTsdKqUnW16tWJ+DQpTqAyJQkVX0rRgranNR6MGWPMierbsm0XOIEcRKzQdg/LTKy5dJxCMXI4/X9XSxcSnbyy8frM5mmu1NHIQYZU/y6IaGwpl0vCfYuYCLdNaZ7ay0mxuHlg0ipz2kj4F+yQDlF3hC5cyz8fajCKf4waD0659fFg+w6AbOD+jx6SY19hFnCl4r1MDISAOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWtDmQPay4QdhkOzEACnxTuB6Tqvka4FDSaWLTVQlGQbKUxwygCJtDw27L7gEESAnaz8VFGJB+YLOeZIRngQ1VqQKK/+x48CAPigWh6/wUDcWGHoLDavE/A3N2o1nIoLDChddC+ferTHHNuvX9pRjs9r0z/vxx4pn5Lp+GfG0gI/2XB9VUvYw4JvT7eYwC0QSR9Lc0AwofewuKdi1j3nEfFc34VE6An3mokd3ssCwLWrAUJCH8VyR9H/gM6Vxt6xI0dqDhrnflDZncndwr4/gppmoPye6M92DVb5rrF1hxoCCyCKI8ZWAx6VNUxmo3lwuxnTcF77flI7SXEuFhyPPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Huang Rui <ray.huang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Mon, 13 Mar 2023 12:27:27 +0000
- Ironport-data: A9a23:+oX4XayxPaC2pG3rQgN6t+c2xirEfRIJ4+MujC+fZmUNrF6WrkVSz WVMXmrUaa6INGCmfNwka9+z9ElXvZSEz9VjGwps+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRlPKsT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVpK9 ewBBQEIVAiSiMiO8b+qRflrpMt2eaEHPKtH0p1h5RfwKK98BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvTaVkFwZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjANxKTOzhqZaGhnW292cOAQw7c2GghvqEjmu4YvxfN WILr39GQa8asRbDosPGdwexsTiEoxcaVPJZFuF84waIooLW6QuEAmkPThZadccr8sQxQFQCz USVltnkAThutry9Sn+H8LqQ6zSoNkA9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q xiDqCUujrMfgNRN26im9lDKmRqlo5SPRQkwji3cXnik9R94bYjjZIul71nUxf9FIMCSSVzpl EMYlteX9vxILZCJmCGHWuwLEJmg4vrDOzrZ6XZlAoMz/jCq93m8dKhf5Th/IAFiNcNsUT/uZ kDXtAIIop9ONX2lRaZyb8S6DMFC5ar9EdXsEOLUZ9xBSpF0eEmM+yQGTWyRxmHklg4Hkaw5E Z6efYCnCnNyIYRqyiCnAdgU17ADzzo7g2jUQPjGIw+P1LOfYDuQVu0DOV7XNOQhtvvY8EPS7 spVMNaMx1NHSuribyLL8IkVa1cXMXw8ApOwoMtSHgKeHjdb9KgaI6e56dscl0ZNxsy5Ss+gE qmBZ3Jl
- Ironport-hdrordr: A9a23:SCkT0a65f6b5DvDy9APXwKfXdLJyesId70hD6qkXc3xom62j9v xG88516faZslsssRIb8+xoUZPoKRjhHPVOj7X5U43PYDXb
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/03/2023 12:21 pm, Roger Pau Monné wrote:
> On Mon, Mar 13, 2023 at 11:55:56AM +0000, Andrew Cooper wrote:
>> On 12/03/2023 7:54 am, Huang Rui wrote:
>>> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
>>>
>>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image
>>> from the firmware instead of doing it on the PCI ROM on the physical
>>> device.
>>>
>>> As such, this needs to be available for PVH dom0 to access, or else
>>> the GPU won't work.
>>>
>>> Reported-by: Huang Rui <ray.huang@xxxxxxx>
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> Acked-and-Tested-by: Huang Rui <ray.huang@xxxxxxx>
>>> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>> Huh... Despite the release ack, this didn't get committed for 4.17.
> There was a pending query from Jan as to where was this table
> signature documented or at least registered, as it's not in the ACPI
> spec or any related files.
>
> I don't oppose to the change, as it's already used by Linux, so I
> think it's impossible for the table signature to be reused, even if
> not properly documented (it would cause havoc).
>
> It's however not ideal to set this kind of precedents.
It's not great, but this exists in real systems, for several generations
it seems.
Making things work for users trumps any idealistic beliefs about
firmware actually conforming to spec.
~Andrew
|
