[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH 1/6] x86/pvh: report ACPI VFCT table to dom0 if present
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 13 Mar 2023 13:21:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vMZq7t5HACCBn4ul1x+K4zW9jH35Wn7eBpGq+8P6zPs=; b=hJoNsBl/mcSckh0hTVxIP500TpSM74qcnSXOftyZ8bArE9x1t1sRqBtGA0AlOf+ur1snstpislT789Pt0LgxTG8mzSx2vN1jYqFApPCuWRJwHP4iv9fLim2u84M5AtJ+fM5DIdJfp/jgtPeBG9SbczY4AlkMOsL7SGVIH5vFk5fbbWEegMZclSCZjk/HoPG4S7BvQ+Ea2wUIz33uaIefGIetxpoMcf8mdxGynpKPEt5+hWgAFM3EUbcQzrNXjbAKYy0asTTxGPuXfNuIpTaMYFWnDjzX63yo24BD59UEoutur/YB1Y4Y9eaVNG/7Mbdd8H2yZ+hBRvIK7fP0IIdNtg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+dHVi4TzkU30fFH8721EQkY8OGyLwGRhoGEugMuuHnQSD2qHWNc7D0B7XFy69LXPuUD7fz8Pho2D9CQnkmEnwBJoIVZRkTj8huwT5VgmtBYT5i85oqkQue0eozs/uE1t71Wg4tiomPRQUsbUlOWc2I/J5RNfQA42Bj363wssR9IKaVTs33bRT51Qr8xcaACAwvsqX895M3UMzhgA7BUP253EAwJ4cPs8voZLd4409kXW0KW96rILI38OCF9n7xYkZ07QXQ690HhGJPCC8YEdY0Mq5SS+wXmSAzUbNtxA2YHUECEBrMv3yT/aFaphZpM12MbjS1xS5kjZZV/MFkoDA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Huang Rui <ray.huang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Mon, 13 Mar 2023 12:21:39 +0000
- Ironport-data: A9a23:JuIc8amng3ESk8C+H7OICv7o5gz7JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIbD2qEPPreYmf9L4h+Pd608U9Q6pfVz4NmHgVs/3syRCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgQ5QSGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dMGeAAGTQ+dvtmn5Jfld9BnreYND9a+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3iee2WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzHKqBtxJROLQGvhCum+r22EJMSctREbk/uSHkUe/afN8J BlBksYphe1onKCxdfHnVgz+oGONuBE0Ut9cVeY97WmlyKDZ/gKYDWgsVSNaZZots8pebScxy laDktftBDpumL6YU3SQ8vGTtzzaETgYKyoOaDEJSSMB4sL/u8cjgxTXVNFhHaWpyNrvFlnYy jSHvCE4i7gJy8IGyq678Ervijeg4JPOS2Yd7QXNX3m57wp/Io2iaoqp5nDS6PoGJ4GcJnG6o HUbktKCqsAPCZ2AnjaERuklFbSlof2CNVX0i0N1DZAl8Diq5HeLcoVZ4TU4L0BsWu4EfjnmZ ELS4EVR+ZZVM1OjaKMxaIW0Y+wo0KzhHJL3VvnSYfJHZ5Q3fwiClAlMZFeR1maru0ghl4k2P JvdesGpZV46BKJ93XyJTuES+bYxw2Y1wma7eHzg5xGu0L7baHvLT74AaQKKdrpgs/jCpxjJ+ dFCMcfM0w9YTOD1fijQ98gUMEwOKn84Q5vxrqS7a9K+H+avI0l5Y9e5/F/rU9UNc3h9/gsQw kyAZw==
- Ironport-hdrordr: A9a23:tQzFUKE4gks52RQ9pLqEGMeALOsnbusQ8zAXPhhKOGBomszxrb HKoB1p726KtN9xYgBTpTnkAsO9qBznhOZICOUqTNSftUzdyRaVxeJZnP7fKl/balbDH4dmvM 8KE5SWSueAd2SS5fya3ODSKadF/DDzytHPuQ6o9QYLcegFUdAD0+67MGqm+49NKTWuyaBXKH L0jfA33gZJGBwsH7eG7yQ+Lpn+Tpbw5ezbiFY9dm4aAcC14w+V1A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 13, 2023 at 11:55:56AM +0000, Andrew Cooper wrote:
> On 12/03/2023 7:54 am, Huang Rui wrote:
> > From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> >
> > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image
> > from the firmware instead of doing it on the PCI ROM on the physical
> > device.
> >
> > As such, this needs to be available for PVH dom0 to access, or else
> > the GPU won't work.
> >
> > Reported-by: Huang Rui <ray.huang@xxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Acked-and-Tested-by: Huang Rui <ray.huang@xxxxxxx>
> > Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
> > Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>
> Huh... Despite the release ack, this didn't get committed for 4.17.
There was a pending query from Jan as to where was this table
signature documented or at least registered, as it's not in the ACPI
spec or any related files.
I don't oppose to the change, as it's already used by Linux, so I
think it's impossible for the table signature to be reused, even if
not properly documented (it would cause havoc).
It's however not ideal to set this kind of precedents.
Thanks, Roger.
|
