[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/vpci: install test
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 13 Mar 2023 11:31:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3rees6DWdA8nFVTTPiYYPjXr+j28HZzV7HqVLweidxg=; b=S7wF+/T9UuN4AmCXaHMynTsgCPl1HeMXpHqteNrH04vxCTjH31y0D5PBqE2fiWE0M8gnsNW5qSxzrR39pL/7dQVQg9hntYjKv642/hRziazh4FD3b/O2E2zsp16mt2sb9m4lcUdrmWK62gmxA1zsagTKPezy6OszQCv75nqU+sCJst3sUoTyOto8UzQjkH/++GChdbpN3q3DZKvz33yrppp7siCbn5jSe9aUlIdm3M/npAev/DWbFAi65eIJ/hu4FxLKgAG4V77i8rSUjyiEKyyTSn+J7xAWGTZR8359IHg5p858BD8sT0o8vZLZVRJDTXd3gS9L3W10wnDOzXGcOg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8D4loh6ynfdBO3XSZsXqartB+fpSzkMYMLtG3REFvNHkOdmrsnOIMSnxEQGyTOica3dSt73fRJDOTSulzI5gk+Z99oKbmMRD8BCeyBAamcjtp0W0TVLz85AJH+jONC/kUH8302nW8pLIusamILJHp+SFS8mzWHZN3kK+utJBk1ebWEcasuA4gmNsHHkd4H8Sqtb3cKzb2qxpTDSPxEXyK56Ib1clcay0pYP3LMjzcTjVbWj1+4HKDm7VSebUyGinPyerU6C131gzw72lMmfRbHVsziAIoyi0KnfoUHM4DGq0ktevmmub6gjDvPnaWJ49T+2IGl2hYFJ4h0/mVh1tg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Mar 2023 10:31:30 +0000
- Ironport-data: A9a23:udp1g6yxVM9qzWIotaJ6t+cRxyrEfRIJ4+MujC+fZmUNrF6WrkVSy 2YdWGqBbq2JMWOmfNx+b4nlpklX75eGzt5qHQBq/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRlPKsT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KSJ2s tg6eQIVUjaKucnokJG8cNdhre12eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVMuuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37eXwHOkBdhMfFG+3qVb3nG3+nI+MiRIU12a/L7jo0ywed0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluP1TM9KGYDYWoBUlED6ty7/IUr1EuQEZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk
- Ironport-hdrordr: A9a23:5almcaFUMoVpvZmPpLqFOpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faUskd2ZJhEo7y90ca7MBfhHPJOkOss1NSZLWrbUQmTXfhfBOLZqlWOdU3DH4ZmpN 9dmsNFebrN5DZB/KPHCT2DYq0dKZS8gdOVrNab600oYRBhaqlm4Qs8IgGHEnduTA0DIZYiDp KT6udOujLlIB0sH7GGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsK67Y/9m rulRD/+8yYwoOG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpsQqsbJQJYcz9gNhgytvP1H8a1P 335zswNcV67H3cOkuvpwH25gXm2DEyr1f/1F6xmxLY0IbEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnR76+8PDW3hR5wGJSEIZ4KMuZkFkIMIjgf5q3PoiFXpuYeA99ffBmcga+O oHNrCi2B8ZSyLXU5njhBgS/DWdZAVPIv64eDl5hiW06UkmoJkr9Tpp+CVYpAZ1yK4A
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Mar 10, 2023 at 03:32:41PM +0100, Jan Beulich wrote:
> On 10.03.2023 14:38, Roger Pau Monné wrote:
> > On Fri, Mar 10, 2023 at 12:06:29PM +0100, Jan Beulich wrote:
> >> On 09.03.2023 17:58, Roger Pau Monne wrote:
> >>> Introduce an install target, like it's used by other tests. This
> >>> allows running the test on the installed systems, which is easier than
> >>> running it during the build phase when dealing with automated testing.
> >>> Strictly speaking the vpci test doesn't require to be run on a Xen
> >>> host currently, but that allows easier integration with logic that
> >>> runs the rest of the tests.
> >>
> >> I accept that as a possible way of looking at things, but personally I
> >> remain unconvinced of this model. To me what is installed should be of
> >> value to users. If there was a properly separated directory where all
> >> (and only) tests were put, I might agree with installing. (Nevertheless
> >> this isn't an objection, merely a remark.)
> >>
> >>> While there also adjust the makefile to use $(RM), and rename the
> >>> resulting binary to use a dash instead of an underscore (again to
> >>> match the rest of the tests).
> >>>
> >>> Since the resulting test binary is now part of the distribution CC
> >>> must be used instead of HOSTCC.
> >>
> >> This breaks the run: goal, doesn't it? If the new mode is wanted, I
> >> think the two kinds of binaries (and rules) need separating (maybe a
> >> way can be found to avoid duplicating the rules, which would seem
> >> desirable).
> >
> > The run rule is not hooked up in any of the upper level makefile logic,
>
> What about the run-tests-% goal in the top level Makefile?
Urg, I wasn't aware of that target. I assume just removing the `run`
target from the vpci makefile would be an acceptable solution then.
It's still the user that needs to explicitly call run-tests-vpci, so
it would better know that HOSTCC == CC before attempting that.
Note cpu-policy and resource should also be fixed, but I don't plan
to do it as part of this patch.
Roger.
|
