[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus
- To: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
- From: Huang Rui <ray.huang@xxxxxxx>
- Date: Mon, 13 Mar 2023 23:57:09 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bthr1QWPFMEqeEDh/KBoh+yxNrZXBaalAi4REG9k+To=; b=GUQOJdF4fZ7B8/hcJL/I+7A8dFtSDs5laUhtLKOpeLT6tU89lyN+BSltV3uxxBhJ8FNS3XnPt3iAnC8dYRgdngEFkI1siWpzOrHGEe9sd2fMcFlfcs1gwrUy+v1+W2JbO1C4JBEdPIM8ELeSJBDq5mSmXZVfnL+QetgPVnwDLBpsq2WffPcca4kPCSNcwafcIwP0pm01ZT7U4j3Hn3rZmDJO7uFZC9XbNiQbunQ4KsUTJDZFi9+TzJwaffDS7mz8b5Nz+UsYkcHwRPwJVm1PnU3uYNA2b2cO5Xk72PlKp0lqM9QUU2hi1EMfanMAQiBIsDmL6Cfs+W5eX/hdc9xavA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LOOr8buJClWzMRvizM8nlA3R6FjVDrQpQnZIktkvYpQ8mCnKjgpbQNrbZlgZu5/6i4wz3Nl8Lfs61hTGZ/jQQOqrkEUvPUxK4s9EhrCVMCUwcq2SHMrCXyb1zfThXO7lMrrNkRHgfBHRewy4VCxGJHDKarh3VOHn6G5hH7YMf4ecMIoZdJZv9YqQ3XBCyuI6LhM9ex2IA6n7H4HIJSggEIK38oo+H8SYJ05HvIxoECPa/SHDdyjGVWGSJDJFgthIRz83tW0Mk43lK/xgIqY6B4oxGet3BiNMP5PsCezC3OF2mOMllzdCYk49k1qKR6M+KoReEmw54PhteZyoBapDvA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Dr . David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Robert Beckett <bob.beckett@xxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 13 Mar 2023 15:57:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 13, 2023 at 10:22:24AM +0800, Dmitry Osipenko wrote:
> On 3/12/23 20:51, Dmitry Osipenko wrote:
> > On 3/12/23 12:22, Huang Rui wrote:
> >> From: Antonio Caggiano <antonio.caggiano@xxxxxxxxxxxxx>
> >>
> >> Request Venus when initializing VirGL.
> >>
> >> Signed-off-by: Antonio Caggiano <antonio.caggiano@xxxxxxxxxxxxx>
> >> ---
> >> hw/display/virtio-gpu-virgl.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
> >> index fe03dc916f..f5ce206b93 100644
> >> --- a/hw/display/virtio-gpu-virgl.c
> >> +++ b/hw/display/virtio-gpu-virgl.c
> >> @@ -803,7 +803,11 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
> >> {
> >> int ret;
> >>
> >> +#ifdef VIRGL_RENDERER_VENUS
> >> + ret = virgl_renderer_init(g, VIRGL_RENDERER_VENUS,
> >> &virtio_gpu_3d_cbs);
> >> +#else
> >> ret = virgl_renderer_init(g, 0, &virtio_gpu_3d_cbs);
> >> +#endif
> >
> > Note that Venus now requires VIRGL_RENDERER_RENDER_SERVER flag to be
> > set. Please test the patches with the latest virglrenderer and etc.
> >
> > The #ifdef also doesn't allow adding new flags, it should look like:
> >
> > #ifdef VIRGL_RENDERER_VENUS
> > flags |= VIRGL_RENDERER_RENDER_SERVER;
> > #endif
> >
> > ret = virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs);
> >
>
> BTW, Alex reviewed the Venus v3 patches a month ago [1] and the review
> comments need to be addressed. AFAICS, you're actually using the very
> old Venus patches here that stopped working about a year ago, so again
> you're using a very outdated virglrenderer version.
>
> Please take it all into account if you'll beat me to posting the next
> version of Venus patches ;)
>
> [1]
> https://lore.kernel.org/qemu-devel/20220926142422.22325-1-antonio.caggiano@xxxxxxxxxxxxx/
>
Thanks Dmitry point it out, I will use the latest v3 patches, and try to
address the comments in next version. :-)
Thanks,
Ray
|
