[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus
- To: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
- From: Huang Rui <ray.huang@xxxxxxx>
- Date: Mon, 13 Mar 2023 23:55:05 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QSEz8N7rHEQJu7Dymta3B4w544klpspLeFSIGoWsUsU=; b=K3PkN408TmMs6fSIgFxw8xDSpQUezK328QL0X0OoOyfRzBi/h3qpQ25CaLIkrWfPADVrrQVWyAsjqE8r/CPRqeEt+SaHvZ9BA1iYZXPVkU0zfPaxWhZMTHoiJ/jdCNDVCjH8yfjozH+R3isKzj7akDRuj5Z2+WiTysbpN2MnYSXFVs6/HGzK42KS60MZ7V4zOkNRRKvuPDGYqKBK8R9SExC4uQA5vVY6GBXvquF86DAQYumSuikBE/e8uB2uVOJJb2WGhk5J0HJRz221iNqwie6jjkKfkIJDeO6P8IOo3YVKQdtPk7L3R2o1R+Xo0pascUkgpoXM3f+25e9EmvDSvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3YN7GPNIkyDopcf/8X8eO1wUvDmHJPqwVIE6VAP6f579VgnGMLavLM3MbsVbK/P3Q7nIuTyUkuzWbP9mEnCm/K5503gDbU9QL0wy94yMB5P6quNUpFs3Zln3G+lsOE3x5AkotZcDR36jr5lo3NhjuKXO04N4tqUnxrFvgFbDvrBR+jT6Ilpu/FI7iCxd3pp9PQ0bNbgrrInjrnG1f9+7i4p8pxcPai0OyKeZPBGxd7pG7Ze85RGZHEC1yxlYlINt4H/FvQXWY2eQr4ZhuLMtUnZyi5zg6drU34zUeF498BEIc3mCYnB75VIu/MzeAXTYpVCJ2leukkqW7xYZtoHQQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Dr . David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Robert Beckett <bob.beckett@xxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 13 Mar 2023 15:55:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote:
> On 3/12/23 12:22, Huang Rui wrote:
> > From: Antonio Caggiano <antonio.caggiano@xxxxxxxxxxxxx>
> >
> > Request Venus when initializing VirGL.
> >
> > Signed-off-by: Antonio Caggiano <antonio.caggiano@xxxxxxxxxxxxx>
> > ---
> > hw/display/virtio-gpu-virgl.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
> > index fe03dc916f..f5ce206b93 100644
> > --- a/hw/display/virtio-gpu-virgl.c
> > +++ b/hw/display/virtio-gpu-virgl.c
> > @@ -803,7 +803,11 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
> > {
> > int ret;
> >
> > +#ifdef VIRGL_RENDERER_VENUS
> > + ret = virgl_renderer_init(g, VIRGL_RENDERER_VENUS, &virtio_gpu_3d_cbs);
> > +#else
> > ret = virgl_renderer_init(g, 0, &virtio_gpu_3d_cbs);
> > +#endif
>
> Note that Venus now requires VIRGL_RENDERER_RENDER_SERVER flag to be
> set. Please test the patches with the latest virglrenderer and etc.
>
> The #ifdef also doesn't allow adding new flags, it should look like:
>
> #ifdef VIRGL_RENDERER_VENUS
> flags |= VIRGL_RENDERER_RENDER_SERVER;
> #endif
>
> ret = virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs);
In fact, we have rebased to the latest virglrenderer:
We check both VIRGL_RENDERER_RENDER_SERVER or VIRGL_RENDERER_VENUS in
virglrenderer, alternative of them works.
https://gitlab.freedesktop.org/rui/virglrenderer/-/commit/c1322a8a84379b1ef7939f56c6761b0114716f45
Thanks,
Ray
|
