[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/cpufreq: Remove <asm/bug.h>
- To: Jason Andryuk <jandryuk@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 14 Mar 2023 11:19:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RHkD6PhycPuvNiAuX72UD+P+GjRnHCGWJNfKJ9noZjU=; b=oQN3OxU+I8tlO6iCt/sq7zBZxcCM+WpSWyGitNx6kZKFR3K6dML6FRzzYgsnpukzXXkHLhLG/FvnGW4szy1FwuILNO08wPhDRT8zynyRHcNZwGelY/ornXsut4JKO7OINl/xaRoZ8PIMES7S00v1puDx9xL0o3Hyqp08bX+q+wVhe5OEy8zCJ89jxqZccyEJeSRAdunuQwmJeg5CrKq7k6MotsD8dvf3NyGEp+QGr/l09hvpwZm8AzFj4aK8kuC4La6y3Sc5kmdfYsvPPn0+nInkRo5ic8FDOUyUv7BXLGgVnXUQHQ3rprZVhRnF/Nn/AiFA3MoPvOyaXUPbZuHt+w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HWj5cI68KjhVCus9HL/9cuWPJvNu9QX9UQkkCyxBKU/ewRQcL2x/ECqAjZt1yQI2sDgMOzkZrd77Y5PF8hADUuv8nkn5Y8dN6H7an+p8zpH30Wz6/QVR+utPx1+T4vc3sexE86oIhncgkidHsg01VMB9c+762hHxbNrZ0xgOZOHFLcMvVyzm5uXxXwY7RIMqGkSv3eeXkPkHt6XBM3w2mCsgZjTB8ERoJBnBVvuEbRlWKU5gSvVzVgyTer4zA+CqqmAowpMZjCMSq6s5u1rRrZrjekTqBHFoJ+q9xvBKFVAd+p2NpddBWYw2ximZq6DQrdSnJhiAzA8pzk7MaeuGbA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 14 Mar 2023 10:19:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.03.2023 18:51, Jason Andryuk wrote:
> The header is unneeded - there are no uses of BUG() or WARN() in these
> cpufreq files. Remove the include. It is still include transitively
> from xen/lib.h.
>
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
This, in a way, is a review comment on Oleksii's "xen: change <asm/bug.h>
to <xen/bug.h>". We can certainly put in the change as you have it (for
him to drop the touching of the two files), but I'd find it more logical
to continue to be part of his change, just with the xen/bug.h replacement
includes dropped. Thoughts, either of you?
Things would be different if it was clear that the change here was dropping
all unnecessary includes from the cpufreq files. But that doesn't look to
be the case, as I think ...
> --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
> +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
> @@ -35,7 +35,6 @@
> #include <xen/sched.h>
> #include <xen/timer.h>
> #include <xen/xmalloc.h>
> -#include <asm/bug.h>
> #include <asm/msr.h>
> #include <asm/io.h>
... at least this one should be unnecessary as well, even more so ...
> --- a/xen/drivers/cpufreq/cpufreq.c
> +++ b/xen/drivers/cpufreq/cpufreq.c
> @@ -39,7 +39,6 @@
> #include <xen/guest_access.h>
> #include <xen/domain.h>
> #include <xen/cpu.h>
> -#include <asm/bug.h>
> #include <asm/io.h>
... here.
Jan
|
