[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] IOMMU/VT-d: Fix iommu=no-igfx if the IOMMU scope contains phantom device
- To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Marczykowski, Marek" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 14 Mar 2023 11:24:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kLW2zZo5GIRGKruWB5MfIxCT1Yidsz6qbWeXC5kzOG4=; b=GFsNsY0bQ1bScDwQHh5rbrifX6PAo83anseM5M2TPHibMQoHW8svpNxn3axQ5JBK1VxOPb248ln4zb/z4Iytk1MmtJ345pMdzHpfeg5gfPF27MF5Hg5aDoItMqgtNOdA4b4d2Q2FnMPt8F3fcqu0UTcp4Fo0J5pP3x2SIkmrR1KGdHZKyA6qkS2s1/XMjaRH93ZBEdD0M/C+PBao2whgX0N3RfcP1hNEMQsWeRgfgz3IlpciLDMJwNaOGB7dBh/V/ZAaT3Lo6tTktj7SzgwNmLLvGlkN1xqCfoe5knyitr//yvfWXumcJM2SC3t4KDcT9b8kRQIhOhEBeip/4+5i5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPFUjAJ60128J3z+vn1quKTnwHaQwJoWMUKzzYW/hQ54U5ihLr5IVw6GBzQ/69ySy25iEehbSi2YHWXdYTmffockVTSFc6cynyjuIlJErLUQzMMVizZkKZUI9ykvTl8o7yVnFeNNpMgGmHBXi7i/5dGH4MhD1r0HyNy67RrB3C15Jk579n6Qm/yJKDgrGq6JhXCBgrbsNaIzyDf2QDlr6+fvRlftY3DzRccp6mws0GTaAihIjhnJe17LoCkDloR6tznq0x4QI0Sm3xH3OJ04eRq5iASgn6/mNmA6LjNDbZO5PfXkRxTWPDPS9hvSv61/XnE8OkcnbsAWlWWdChDl6A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 14 Mar 2023 10:24:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.03.2023 02:50, Tian, Kevin wrote:
>> From: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> Sent: Tuesday, March 14, 2023 9:32 AM
>>
>> If the scope for IGD's IOMMU contains additional device that doesn't
>> actually exist, iommu=no-igfx would not disable that IOMMU. In this
>> particular case (Thinkpad x230) it included
>> 00:02.1, but there is no such device on this platform.
>> Consider only existing devices for "gfx only" check.
>>
>> Fixes: 2d7f191b392e ("VT-d: generalize and correct "iommu=no-igfx"
>> handling")
>> Signed-off-by: Marek Marczykowski-Górecki
>> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>
> this should be rebased on top of Jan's patch.
Right - I guess I could take care of that while applying. But I wonder
whether the description wouldn't then want adjusting some as well. Or
wait, with the v2 change it should actually have been adjusted already,
as the igd_drhd_address determination is now (intentionally) also
affected.
Jan
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
|
