[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] IOMMU/VT-d: Fix iommu=no-igfx if the IOMMU scope contains phantom device
- To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Marczykowski, Marek" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Mar 2023 09:22:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSvYwoib5DH5FKwteqcEQP7Khci2CxcJFttYEbLgq3M=; b=L6uxtKOaP7M8jY40J7qrBaIKLEj347pr5QFliBuV1GbKJrEVIIM2WIavQ9FYiJb/1CVPmitvKdq3hCnsmjSOcDo9jxgJuy///9WVrZfil2GyDVBcjyyUF6r+PEz/Ts6vMYqAPtvPXoaCVALLSbMoZElGHJwbi5X21leGHY8OxrzqtaVjcbXUoYBsPhqt+zJbpUeWkBNnjRsWm5FBHHzAEVY0tcV15ECBWWba888BxbLyJvkf49QXn6QYMGNJuMzNs2wCcjTWsvujIPvVyrRbRs8vmeVQGXTP0oCBU/D4UcrkmUHmUvLtme5p3fGMbi07yE6WQ2FruZiawRLAhbAmIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzKUtBgsP8oZyY1NdnZMG9w6szom5UQnaeShIB/jUbPyIYrTt0GrNGwQStshXw+eWFVqubTposJOGNBNUEg1KF3/gtkLCPixVzbqB+kxDw5P4lNAv05kyDRJafg95tXXOhXc9/X2ey3kaYpRHTWPsNvNYFhZfdI/dz10dnAsCSMfZIqNiTrLid/IODnfEUo6kg4u7/Eflj+g2Wmw4/3koN9ZQCYTCwlbBSLmUiC37TcXpoZDq8Zx/DwrnQghyekBNJ6pxgHmDRoMb6ISQ0UL08RsQTlAcoPwx9PVkEDD8VMffGh/tmVRPm1h9z9IMtaC+8zaI6bZir1IbuDf/8/61A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 23 Mar 2023 08:23:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.03.2023 11:24, Jan Beulich wrote:
> On 14.03.2023 02:50, Tian, Kevin wrote:
>>> From: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>> Sent: Tuesday, March 14, 2023 9:32 AM
>>>
>>> If the scope for IGD's IOMMU contains additional device that doesn't
>>> actually exist, iommu=no-igfx would not disable that IOMMU. In this
>>> particular case (Thinkpad x230) it included
>>> 00:02.1, but there is no such device on this platform.
>>> Consider only existing devices for "gfx only" check.
>>>
>>> Fixes: 2d7f191b392e ("VT-d: generalize and correct "iommu=no-igfx"
>>> handling")
>>> Signed-off-by: Marek Marczykowski-Górecki
>>> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>
>> this should be rebased on top of Jan's patch.
>
> Right - I guess I could take care of that while applying. But I wonder
> whether the description wouldn't then want adjusting some as well. Or
> wait, with the v2 change it should actually have been adjusted already,
> as the igd_drhd_address determination is now (intentionally) also
> affected.
Since it wasn't clear if/when a v3 would appear, I've done the adjustments
myself even if originally I didn't mean to. I've also adjusted the title a
little, first and foremost to replace "phantom device" (which has an
entirely different meaning in PCI).
Jan
|
