[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/10] tools: add physinfo arch_capabilities handling for Arm
- To: Christian Lindig <christian.lindig@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 15 Mar 2023 10:15:42 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M44KkEcudMsCmROre+b8V6tDscpGbXAchGDhT8JJA+A=; b=Iyo0ThSvuqgp7ROgu6/pGHsngYGsgavg5Hfq6JOuTDZ2DS6m2p7gZO5dNeZF2yxEUmhpYuYX6RFQc9iftEopssvrPDbRjC1YLgvOcFkGzbu31suQV1thQRIkZCWOa7rGytwx8qxCcNKZIov5ssobVQJLdEdDUsTPu50zuMxXSDKi1GvL/WkwT7VN0XKte4RKhAq2X0Uj7IbfQy0L5mhkPKTLNJ5CYcFr+qjqvzttuvTD+2TcZWppLpba3jMQ9oxexnkriQSa7jNgkFa/iT/0ooglygFfTqhCsaKp304IU/U6C0jCJ/S+vRj2NVq/X9pXfdkETnV3ccB5S1ebhRGjGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DbL8Qiqy21c78+QfHl0yGegRuVy5GX+9XVFZH+g2fZPEB59Y72wK/q8LRUFt/DYDnrBoLSzRClGf7xb/uLMFiDkWZkf+XA0HqoVfSiFWh4YkoOMyNvjmG2lMDlCYfU2WqBQgOO+sG9BLUi2/yDSRneSVVKfW9IvVPstBCSUDan/vT7YQ2Zjj8KjHU6s6dfAMHCGMuk636qBoEAM4iUdMAujkrViD54aicUWxb5ss+rxswchxdIf+7WVKF7khq5Mcggj0G8h8PPhTp9Tk28fLe9MmPYOT2RsXa+W0vjFR5sK0w/DzXqLlWcRe++Jr3MJQ7ZUtvRXPZB7KLAz3GRxN5w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Edwin Torok <edvin.torok@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 Mar 2023 10:16:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZVx18izX66CL0tEu/wMOArdtab677mNIAgAAHGIA=
- Thread-topic: [PATCH v2 08/10] tools: add physinfo arch_capabilities handling for Arm
> On 15 Mar 2023, at 09:50, Christian Lindig <christian.lindig@xxxxxxxxx> wrote:
>
> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>
Thank you, I might need to drop the ack in the next serie, because I need to
rename
arm_arch_capabilities.h to arm-arch-capabilities.h, unless for you is ok to
retain it.
>
>
>> On 15 Mar 2023, at 09:05, Luca Fancellu <luca.fancellu@xxxxxxx> wrote:
>>
>> type arch_physinfo_cap_flags =
>> - | ARM of arm_physinfo_cap_flag list
>> + | ARM of int
>> | X86 of x86_physinfo_cap_flag list
>>
>
> I notice that other capabilities are split into a list and not kept as a bit
> field. Is this not needed here or am I misunderstanding the representation?
Here I might need someone with ocaml knowledge, because on arm now
arch_capabilities is not a bitfield, I have used “int” instead. My understanding
is that to generate a list there needs to be bits set in the field (I might be
wrong though).
Maybe Andrew or Anthony can guide me better?
I understand that Andrew is not really happy with this way to handle, but this
is only until we have a proper framework for the capabilities.
>
> — C
|
