[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/10] xen/physinfo: encode Arm SVE vector length in arch_capabilities
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Mar 2023 14:35:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ge57tYwOKuVOWCSoR7DRduaQM4y2MKQzAlzX9MKjVC0=; b=H6UJxjdmfv0JQUtNX9o9g6b1u//pPTqdniXmgX2gGwObfzRm7EGYaUSgHaeuXpFL4DR0z3iMw9oCT0pDkUxqDldsSzsYJdb0eHoUeU1FnXpPxSBrJE/HRmsJ3Qn8c0Sz3t7u1oWqWkSNeJBG6qTvGHb4Dx3TELGIPTbltn6PqzMvcbphSaDdEr9sQi7OdnKGgFcdByObw/MVc8uyOClKxm64IcqWbhKXxOoRVaPpTVu1/wg0Hpa8KqtExxPU0OTFdTsEY6oglYt60gWGOATEKmAvCBSruoy2wMpLD2UzI3F2NUAuZHulqKRQezoV3vtJmqKSTrHk9yxcH8bTNeC/UQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqyIhql0jYSVIAOKCcRoYAgpqk49KA4FfcJLJnJEjQYlqiOtEXmVdlI2BMYPYbycF9ln5pdujd1DugM45sthmJM4sq+A027tYGJiPL7yd37W9UZO+z/qKmQUXuqW0lcwYqhwjKQr5bmwAnX7k222YdADxe1x+tNdhGDy8GtY0hnYjO7VUW5KXWFmpwTnfqo0gsg8G5DgvgyeajiF5ejRaUFw37pj/SFesCxgzJJqhPpv+1fCCLt26+VLSDA4TOjmmnMJpo9dZKzwFvc8vUO5XAdeA1FOpmgQfqiThQEGSd/5H/VwAIhN6s7WrakJDnAdKlF3hWqD0e8M2768sAm7Cw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 Mar 2023 13:35:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.03.2023 11:39, Luca Fancellu wrote:
>> On 15 Mar 2023, at 09:41, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 15.03.2023 10:05, Luca Fancellu wrote:
>>> --- a/xen/include/public/sysctl.h
>>> +++ b/xen/include/public/sysctl.h
>>> @@ -94,6 +94,9 @@ struct xen_sysctl_tbuf_op {
>>> /* Max XEN_SYSCTL_PHYSCAP_* constant. Used for ABI checking. */
>>> #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
>>>
>>> +#define XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK (0x1FU)
>>> +#define XEN_SYSCTL_PHYSCAP_ARM_SVE_SHFT (0)
>>
>> The second of these can be inferred from the first, so I'd like to ask
>> that redundant definitions be omitted from the public headers. For the
>> code using the constant we specifically have MASK_INSR().
>>
>> Just like there already are x86-specific sections in this file, I think
>> the remaining single #define also wants enclosing in "#ifdef __aarch64__"
>> here.
>
> Thank you, I wasn’t aware of that useful macro, I will use it in the next
> version and I’ll
> enclose the mask using ifdef.
> Are you ok for the position of the mask define or should I declare it
> somewhere else?
The placement looks reasonable to me.
Jan
|
