[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/riscv: Fix build with GCC 10
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Mar 2023 08:21:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Ra9nsZr7hsuaRVdoh/9C9JwzoJ5b3wRRX6LQU36pf4=; b=S+cg6XddlNjFiTgOkJWKjrub7rRM760AN9MtKmz3POJn3cG1YJT2+h83iqsHT1+Cp4m/VV+TlgP1fWADaBUgpiGI15Nb4JnuCHM9fOzocXkcHdpUFESN+TjL4KodKX0wQp6eF6abE0MhsWXARJpLfvhH9uMnLlGOPbrIFBRN55pePYC/RPyMvVmc+2iTEplF/t4QWvLnSn2b1tRLbCyy7yI5lYnfGjiwCwt0KEWIZJYVkwdZTv30eNzPpjmikaH7g+bGecS5PdfGAzMDcqq3kAiKkGJuX/rWz3g5t3gawuWa6vA0Y4A5GofM3AzgZQ7GPC3Pgty/eH6rDByIOc5KfQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqFqhSCegkfNWbUIfFo54BVRuAxGo194wiboRzs0w/ZGhvS2lQIDaYq1idY44i+olIcPeMFF5YdjtwzDS0EJ57TSus0coua+jtI7hUvxyUUv6iqBmnS8FJlh+A8k/vQv4RWllGppIyxDeOaq+IiOAvH52JqyGRAvVONCvWz3QIxtxYZqYrLEsmWT1wyqLe/qmFy38eH3whoSr+/ghlQME2mCwrhoXeMvhCvE5q0Xbx6AmY2umGOocZB27aHVUOt8l9R6L4/1Bzz3eDLjMTWB0UBmfVhf7v3k8ElObiDep89+1hPnR+akeIwRuSpdIWP8yS6Cps/EqN9PxzZjEdtWPw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 16 Mar 2023 07:21:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.03.2023 19:51, Andrew Cooper wrote:
> riscv64-linux-gnu-gcc -MMD -MP -MF arch/riscv/.early_printk.o.d -DBUILD_ID
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
> -Wdeclaration-after-statement -Wno-unused-but-set-variable
> -Wno-unused-local-typedefs -O1 -fno-omit-frame-pointer -nostdinc
> -fno-builtin -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla
> -pipe -D__XEN__ -include ./include/xen/config.h -Wa,--strip-local-absolute -g
> -mabi=lp64 -I./include -I./arch/riscv/include -march=rv64gc -mstrict-align
> -mcmodel=medany -c arch/riscv/early_printk.c -o arch/riscv/early_printk.o
> arch/riscv/early_printk.c:18:2: error: #error "early_*() can be called from
> head.S with MMU-off"
> 18 | #error "early_*() can be called from head.S with MMU-off"
> | ^~~~~
>
> $ riscv64-linux-gnu-gcc --version
> riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110
>
> The binary is otherwise correct, so remove the incorrect check.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I'm with Julien here - this needs further explaining: The compiler (even 8.2)
clearly provides this definition with the given set of command line options,
as supported by trying it out om godbolt. So there must be more to this -
could be a bad patch in Debian's build, could be some odd interaction of
command line options which for whatever reason only triggers with certain
builds, or about anything else.
Jan
|
