[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH 4/6] x86/pvh: PVH dom0 also need PHYSDEVOP_setup_gsi call
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Mar 2023 08:05:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pi2kHMkPYV3nxr2IOWClX+KB5TfpBTF746lgJCCTi5E=; b=IN1g9i3Bb2VFNQok65mGqIqpj16GCA+8lmOWB+hDd1Lo3CB53jil3bNUlqm1ofIGaWSZ+oV7A9cvBo+cgIvaRtlVkrmdZs7xgbHjsB//FWNaRme0Mro1AJA5HuCzDicHAccuY38TMlgBo44KHZh5PwQpX5mVEe1VVzOOdjwylW24RNv3CZ+LHp647cOrYX0XMkMaZzMgCo/bv46uKcEHc2/OgcnrKFjUTRmdqqot3AkQM4VTsQKv4M+jE7DamEzSNODDetIw/Q0F3Wnysxg4RvVChia1NlHQ64cJxt0DEyKnaV3hkrg0jThI68iydRBtfB+Wl+9SsJafmjeVO2YxEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UgliI9d15DgojbcBlrGzTjCLP6fhShFibsafj7+esIt07I6XVjXMo2uLacBOWTggvaTvnQdRf5K2KejIad1Wi+9EKZ8wKu9fAtFXk3VROBdT+KwPt3KDfYRTWR0QwjHUgap5yaCXWCZBfhrXIKaYZM3dcKl6dN5q4a0E5eliqFGDTIk3SUzdTatPUhk5BCbfXKAiwcPiVJ3ZMp1kvxlQjaUuw7nwA0Ww/QrsoTZHMgDY/adHKghF3m5L45l8EgOVWZqH5wFVLwoVwIZi5omQIsr8EE218EudYguy2KZAFSUJk7FdgP4wKmSgpGqaZQveqTZbTr2YZnZScpoGPaVrOw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Huang Rui <ray.huang@xxxxxxx>
- Delivery-date: Thu, 16 Mar 2023 07:05:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.03.2023 18:01, Andrew Cooper wrote:
> On 14/03/2023 4:30 pm, Jan Beulich wrote:
>> On 12.03.2023 08:54, Huang Rui wrote:
>>> From: Chen Jiqian <Jiqian.Chen@xxxxxxx>
>> An empty description won't do here. First of all you need to address the Why?
>> As already hinted at in the reply to the earlier patch, it looks like you're
>> breaking the intended IRQ model for PVH.
>
> I think this is rather unfair.
>
> Until you can point to the document which describes how IRQs are
> intended to work in PVH, I'd say this series is pretty damn good attempt
> to make something that functions, in the absence of any guidance.
Are you advocating for patches which don't explain why they make a certain
change? Even in the absence of any documentation, the code itself can be
taken as reference, and hence it can be pointed out that either something
was wrong before, or something needs extending in a certain way to make
some use case work which can't be mode work by other means. In the case of
this series, without knowing the "Why?" for the various changes, it is
also impossible to suggest alternative approaches.
Jan
|
