[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH 4/6] x86/pvh: PVH dom0 also need PHYSDEVOP_setup_gsi call
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 16 Mar 2023 10:18:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zeDgwPxXeVZs1PypmdYNODInBTn84U3CB2OPdRnREVM=; b=ZiUnkVFLAKSWR+Bl7cLfW24+IEtJvQ498xMtMtW2D65/VN4aoijt5hXpSukaM7PKK2MNURLYkv885HV7b5mXgAA+UDpIdy4WqjC4Y3d8g8EuxH8tDWZlxxZLZcpQJXGw3lEFGYYJe5E4VM7s9oq9IOUHyUVPZ5BTBm+2nz1dFwdIBJovNiGpSANxqvjRVjUzvGTLlP7re/3vpmAXHvls3QWhhli0u1ErLVRY/uAkWoS8/A63xo3wiynPuij7PYqgN34xm5hOcWapHdwiRTJ0ucqQES782M/3/YMfAZRPrmqTn92Yw75vKkiW19BtlGYZ/Gn5bHHFK5J0Yg0HymQ8jg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xpy0zRWij0lZIS1RRRTFUuA1C28WuhPxTqXYotGnN4v4rlBs82FjuK4rl4orcAqAKfDBLooZ4ef13t1vJJtWcUD7oMp9mWZceleSYbYZduUsJR3qSvhv/8dv4b8Ni1qQX6GRA4EKvZBsm6WCLvtYyj6/G0M5lTNt1rBJzJtlicSk3kJO7H6K3dKfUP7cxD7DNa2g0DufezPL681+4LhpNKuYM8o7LepHQsPN/by8pEQqKBUy3yxgzASqe/7YEo7fHK4Le4Ire7frGBYAAt3tuU4C/L4+pXRiGLyK7s6Sa3FYQLyHZ9Z8/QQ5Hlx/zi33hOE+ecNbN3rvzSXrrMbx7A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Huang Rui <ray.huang@xxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 16 Mar 2023 09:18:41 +0000
- Ironport-data: A9a23:wRvghqiNn2K7MpW3xRKkyk61X161CRAKZh0ujC45NGQN5FlHY01je htvD2iFP//YYzOmfd9+YYmyo0gPsZDWmNU2HVA9qytkHiIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT5waAzyd94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRHLW4hMwqZn9ufzbGQZsYyj9hkBezSadZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGyb7I5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqjAdpCSeLorpaGhnWUhXUuKj0nZWKCvNSD10SHfuNfD FELr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLP+BqQDGUASj9HafQludUwSDhs0 UWG9/vzDC0psKCcT321/7KY6zi1PEA9JGsPdSYCQQYfpdXuvYozgwjnR9NvVqWyi7XdEjHqw iuWrSE4wbYUgMgK2I2y+FyBiDWpzrDyUgMq7x/LGEKk6g90bpSsYYCA4F3Xq/1HKe6xRESbr nEAnMSZ8+kmApSElSjLS+IIdJmp4PCKNDDd2BhvApAn+Byk/nLldodViBl8OUNoO4AWeTbvb 2favA8X75hWVFOIbLZ2aoT3IMQny4DpENijXffRBvJeb540eAKZ8SVGYU+Lw3urgEUqibs4O 5qQbYCrF3lyNEh85D+/RuNY27l7wCk7nDnXXcqikEvh1qeCbnmIT7tDKEGJcu0y8KKDpkPS7 spbMMyJjR5YVYUSfxXqzGLaFnhSRVBTOHw8g5U/mjKrSua+JFwcNg==
- Ironport-hdrordr: A9a23:FxZnCaqGZ8FpiYZAAKzA8TMaV5oWeYIsimQD101hICG9E/bo9P xG+c5x6faaslcssR0b9+xoW5PufZq/z+8R3WB5B97LNmSLhILBFvAB0WKI+V3d8kPFh4hg/J YlX69iCMDhSXhW5PyKmTVRWL4bsb26GXmT9IDj80s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 16, 2023 at 09:51:20AM +0100, Jan Beulich wrote:
> On 16.03.2023 01:26, Stefano Stabellini wrote:
> > On Wed, 15 Mar 2023, Andrew Cooper wrote:
> >> On 14/03/2023 4:30 pm, Jan Beulich wrote:
> >>> On 12.03.2023 08:54, Huang Rui wrote:
> >>>> From: Chen Jiqian <Jiqian.Chen@xxxxxxx>
> >>> An empty description won't do here. First of all you need to address the
> >>> Why?
> >>> As already hinted at in the reply to the earlier patch, it looks like
> >>> you're
> >>> breaking the intended IRQ model for PVH.
> >>
> >> I think this is rather unfair.
> >>
> >> Until you can point to the document which describes how IRQs are
> >> intended to work in PVH, I'd say this series is pretty damn good attempt
> >> to make something that functions, in the absence of any guidance.
> >
> > And to make things more confusing those calls are not needed for PVH
> > itself, those calls are needed so that we can run QEMU to support
> > regular HVM guests on PVH Dom0 (I'll let Ray confirm.)
>
> Ah, but that wasn't said anywhere, was it? In which case ...
>
> > So technically, this is not breaking the PVH IRQ model.
>
> ... I of course agree here. But then I guess we may want to reject
> attempts for a domain to do any of this to itself.
For PCI passthrough we strictly need the PHYSDEVOP_{un,}map_pirq
because that's the only way QEMU currently has to allocate MSI(-X)
vectors from physical devices in order to assign to guests. We could
see about moving those to DM ops maybe in the future, as I think it
would be clearer, but that shouldn't block the work here.
If we start allowing PVH domains to use PIRQs we must enforce that
PIRQ cannot be mapped to event channels, IOW, block
EVTCHNOP_bind_pirq.
Thanks, Roger.
|
