[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC XEN PATCH 4/6] x86/pvh: PVH dom0 also need PHYSDEVOP_setup_gsi call


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Huang Rui <ray.huang@xxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 15 Mar 2023 17:01:52 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bRStwQmr7cCA8/bDDT6jRWnhNxuopOkWIaWXEhSIIMc=; b=LRdIM9+it3p8IGKjuT1T/RWL1bpBS12t3XUxh7eh/JIvhX0l9IO2b8L0jdci+EkpFyk6e45SJoHkrySMzQEwo7xHRGQu5/vo2XP3zEgpNdrA8Dq7gaoJ6V+ltnCBSaJ91kCPk5jh4NOLCo5m+yLGQSrAbrztLa4DYbKo3p/RtNI5qjnpDY6CL1WyI6EB+n7noftJtZ/1OwC3CAS/ULJMErFFvTTTVLw0LsnuN2S5ljfswpUbWDIsZgWQ/nHQu/DGiZo3UMU4SneCgAyAOHqf59U9TBaVxhpMhpQ5TLtT5ek66RV/p8dwHJ95lKxJmAc07SYfC2NAC0uLNRuzIpx35Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SpwLGJ4z4t/P8M/Ju3sx7nat3+fHei7oFNrCaXxvJQhpPupI/s2JIzni9B40qUrx6MK/vZI7t6FFCLpe8+A6UAkcLytcf8FoExWKLbPYNBgpXcL8rBbqP+s4LtVCUC7gKVibIBir6DhoCZB66knCwZ1OX2woxzwJwLfrxKQqYjx/STOu+F5/XxBtq1ydVbwD9UnY4YdoZmUKjrPnZbZKrsBm53D16jdoFqR92ey87RZNDk3HL4gZOiD4xXjTjKe9J6EhjTt2LRWfznsSUfPmYITvj5ig8hrvsuAhD0GyysqhDZW3hwDvtKTeRoTkSlUasY3I0RQqaEfGMEuMmF5HjA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 15 Mar 2023 17:02:22 +0000
  • Ironport-data: A9a23:jbHATKodq85z/uYn2Bnw5NzkVKBeBmJsZRIvgKrLsJaIsI4StFCzt garIBmGPvjYamr2ed8gaI2zoEsDv5/dyYBhHQBtqy42Fy4V8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weFziRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABEuZBvape3t+4KcQc08hcAZNOXRNpxK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKJEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqY72AXImD175Bs+CBibnsGjjwmHQMNhA WsfuSA0s4JvzRn+JjX6d1jiyJKehTYeUddNF+wx6CmW17HZpQ2eAwAsVDdQLtw7vck5bTUv2 hmCmNaBLTVrva2cT36Q7PGYoC65OSUPBWYHaWkPSg5ty9LjuoAokhPGSJBgF6Ozj9LdEDT8h TuNqUAWvKkekscRy+Ob/FTLjji2r57FZgcw6kPcWWfNxglkfpysY4uk7kfSxflFJYedCFKGu RAsm8+Y4+QDDMjLlDGERuolFbSlof2CNVX0g0NrHpBn5TSk/XGLdIVcpjp5IS9BEMcdeDbvJ mTTtAV57ZpfenCtaMdfeJmtAs4nyazhE9XNVf3OaNdKJJ9re2ev7CxoIEKdwW3puEwtir0kf 4eWd962CnQXArghyyC5L9rxypcuzyE6gGbMH5byyk3/1aLEPSbJD7AYLFGJc+Y1qruepxnY+ MpeMM3MzAhDVOr5YW/c9ot7wU02EEXXzKve86R/HtNv6CI7cI39I5c9GY8cRrE=
  • Ironport-hdrordr: A9a23:w4LBgaCT6BRZsUDlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/03/2023 4:30 pm, Jan Beulich wrote:
> On 12.03.2023 08:54, Huang Rui wrote:
>> From: Chen Jiqian <Jiqian.Chen@xxxxxxx>
> An empty description won't do here. First of all you need to address the Why?
> As already hinted at in the reply to the earlier patch, it looks like you're
> breaking the intended IRQ model for PVH.

I think this is rather unfair.

Until you can point to the document which describes how IRQs are
intended to work in PVH, I'd say this series is pretty damn good attempt
to make something that functions, in the absence of any guidance.

~Andrew

P.S. If it isn't obvious, this is a giant hint that something should be
written down...



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.