[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC XEN PATCH 4/6] x86/pvh: PVH dom0 also need PHYSDEVOP_setup_gsi call


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 16 Mar 2023 09:51:20 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4bMf0nSAryeiy40tM2oOV5O3DbwL13Jwkscwmpft8J8=; b=Dx2pYn0Pe1gAbS+xt/GFpQMDlQqOi33q7Kf5j2cVoLGsVUQRNcyHU+F1NhaZ6SkXcD16TD1PHLS0jEmRIHYy37BVpmYbKviT0Kd3F1RyhjKOQidFdZnkBq9pqEKtfHpgY01oyi8hHzlGCTPYx+qDa4dYvivOasH9T/YAs2CuB4U+joZdR+pGwZ5m5jYTx8SaN+atunx+2f4byc8wgq3D1d4HBjfQCBCWMeaCGUmMNAJhZ/yU0eDyiNHm+UfKGBRZ32ASIX8ZAJbInnGmGVXtw44MjnSyEiH05QMxz0hQRFykbhKmAUrQuBO8mQkLQ2BFY7FPE2h28Hg5PHi7StLPsw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgZnhibQxfJ9YrpJWORFG3buO96NsYMF988cDWZUl8bzsTGta8aAoFw0CLt71BmlbPguK0x3hfr81ucUC0/eraQMnaJ0aj20d/6l1UbqPUE8r1nyrbVZrZBAunO5/F8/SaxQz8FfmoIwDV6ZNEWKBHhbBviNECQ2g4kH0WK+maiuXPEGpIgolgAB6DJz3itF+ZlC+IVnQdXvYQnBylagoj9FieKz7xj0Pr+3NpWvAhWXnbNd0q4OzPYFrcCb9my9ZeXlK+/vQdZVfA0yuoYU4jN+vlIu6kSadRe5Oc/14XtLl4GFulbdcu+Z0B0eObxMVArKNRv96+/epjTnZIA4EA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Huang Rui <ray.huang@xxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Stewart Hildebrand <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Honglei Huang <honglei1.huang@xxxxxxx>, Julia Zhang <julia.zhang@xxxxxxx>, Chen Jiqian <Jiqian.Chen@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Thu, 16 Mar 2023 08:51:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.03.2023 01:26, Stefano Stabellini wrote:
> On Wed, 15 Mar 2023, Andrew Cooper wrote:
>> On 14/03/2023 4:30 pm, Jan Beulich wrote:
>>> On 12.03.2023 08:54, Huang Rui wrote:
>>>> From: Chen Jiqian <Jiqian.Chen@xxxxxxx>
>>> An empty description won't do here. First of all you need to address the 
>>> Why?
>>> As already hinted at in the reply to the earlier patch, it looks like you're
>>> breaking the intended IRQ model for PVH.
>>
>> I think this is rather unfair.
>>
>> Until you can point to the document which describes how IRQs are
>> intended to work in PVH, I'd say this series is pretty damn good attempt
>> to make something that functions, in the absence of any guidance.
> 
> And to make things more confusing those calls are not needed for PVH
> itself, those calls are needed so that we can run QEMU to support
> regular HVM guests on PVH Dom0 (I'll let Ray confirm.)

Ah, but that wasn't said anywhere, was it? In which case ...

> So technically, this is not breaking the PVH IRQ model.

... I of course agree here. But then I guess we may want to reject
attempts for a domain to do any of this to itself.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.