[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/svm: Provide EXITINFO decodes for IO intercetps
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Mar 2023 11:19:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Bn+S/2eYfVZvHWIeQFr3qM8VkqvI7SaZtJE1PiDRQc=; b=Y2dQQaWz+Dus+ipvgpHUOrOxRsy+pVQg7+L0a7pDllsEATu76FMl7u+2td6+dyKisCJ3OZwrbbjtL7eJfTvrR2jpP+ZykwrRwHF0NoxqBI/jfEUKch35kIK+5AXZdwK5yTsFRi3n5Ql0xy48FFbM5DC3MLkVb2eNUgYe+DLGQrW1js0nLjS5HqqMz8xJkNm4T9aZurDkHaoYTkb01oy3m931zdOjhTvvLmKi9MAppgXo4YxBeZeHh+LBzPBCwDltsPP4eH8kI8eezLOw23CrmDFXnqiAofxhjRU6wAdlLmPv94mLi/8z9kxI2lVLKLGpkO45Grj0jfIn5hDCXAzcSw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U8HlnTUYBFTqaGkUpaiLhctlZSzDaKoTubzRImluKWj++ZEJ7n92THnyvvCoLisPgyqk6tr5BOvB/Sp/0v9rJj+uqnNr0zzwdm5B+a4GkEjsS8Vh+VOwzeG78xIpJIZXBSgCd6Zh687X9EtSeMB918QFYzuq59sb/FgMhx9D2Mp7ErqR7Csssu5sahzdwZDv1EI+A3Pcdk4i2edzwScwvFznX5K5mHbTIni4BCtI4nA2pTs9jobiMn9Lo48DKlXRyHfzSFjWjL1JhRYaU7+02xFyWb8YH4063qJE/ucDDwFqBPhMvgODuKUi8kRhnmOLo+Rk1Pzaoup7+hG4h5e88A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 16 Mar 2023 10:19:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.03.2023 23:10, Andrew Cooper wrote:
> This removes raw number manipulation, and makes the logic easier to follow.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
But I have a question:
> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h
> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h
> @@ -436,6 +436,20 @@ struct vmcb_struct {
> uint64_t exitinfo2; /* offset 0x80 */
> };
> union {
> + struct {
> + bool in:1;
> + bool :1;
> + bool str:1;
> + bool /* rep */:1;
> + uint16_t bytes:3;
> + uint16_t /* asz */:3;
> + uint16_t /* seg */:3;
Is there a particular reason you comment out some of the field names? I
can see that "asz" might be a little odd to use, but both "rep" and "seg"
are imo fine to have a name even if currently there's nothing accessing
these fields.
Jan
|
