[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/3] libxl smbios support
- To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 Mar 2023 12:53:09 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/jvKDojcsWkrZuuTJGA2rE5O2T+40xoTh5MhrJyJ40=; b=NEs9bgLwbhNudO5fICWrJk7x/60kfEux1uH884/F8BoZfkn/DSB7+szfn8it48QZcfAg5YlzJHWeTgQJoMFc6xwk7Imu3Sd83mG6ggjTnqy4Vp2w8cCI97xWLGvpyYua4Lvy1NQzE6fmr8eIX71AXybDbQ3idrEZVtxjITAZPuFqmQJlvm/y6lJG2tga/UIqnqjdBjr3sUDc1eR13CE+w6fMFQazEMzGJPq0kdJWrz424pyXmquxTEFs/Gg9YjSf5scnPbUQ8rJov46A73SA4ixfmXC6pTGVZS8ViLIazxXfzzJ+kUZDoeIYMmFrFWeSP4NEflH5gpmnHivZ0bzAag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DfnTCpcigGbeeDCmsLvmzjJejpdmVy5QbqwGYwgXFMuIPYLlEQQ1+ggfz/JPjEritcF5XXJkDpdncvelnZKM8ni5LbrKBSLabxOukFMJ/xZZz0LnqAKZYGiLYe8Q9kYBZn2k9kK9JSZckjTh4iLKvaTWtN3UnvqrHTsq7MXiJTIlRULNxy3J6cOLFCH7XWcNgNqsTGS4Ot3XulcRUxmtwgxz3ANVR7B7FsCoaFYd0AgZC3wqe7UG6b3F1efgZFXafGGKU/A9RyzykEFF6taQPQwRIQPQFeMDvGKfPz0mmqEM89RRoc7wCOWh+ul47r6ibhOA0cNcYyIxqsLxZG9NGQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 16 Mar 2023 12:53:36 +0000
- Ironport-data: A9a23:OXtpYauEDYINrWB7T+UssWwas+fnVKZfMUV32f8akzHdYApBsoF/q tZmKWjXbvyMMTbxfN4gaI2/9klSsMWHx4JjSAA6pXs1Hnsa+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5ASHySFLZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwFg4VMgmEvNmNnpm/crBciPgKMuixI9ZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xbbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXjq6Q12wfKroAVICI/ZGWbo9K6sUP9V45+E nAY4nMrl6dnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLmoNSDJbecElnMAzTD0uk FSOmrvBJTFpqqzTdnub+Z+dtzb0Mi8QRUcYYjQOVwwC4N/Lr4Q6jxaJRdFmeIaqivXlFDe2x CqFxAA8iK8UltUjzLig8BbMhDfEjojESEs56xvaWkqh7xhlf8i1aoqw81/Z4P1caoGDQTG8U GMsnsGf6KULEsuLnSnUGuEVRun1urCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC KPOhT5sCFZoFCPCRcdKj0iZUqzGEYCI+QzZa83p
- Ironport-hdrordr: A9a23:ma3w+a1joRDtWeRGReqV4gqjBdVxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ/+xpOMG7IU80hqQFmLX5XI3SKjUO11HYSL2KgbGN/9SCIVy2ygc+79 YGT0EWMrSZYTdHZK3BkWqF+qMbsby6GdeT9IXjJhlWLD1CWuVF1UNUGwybGkp5SE1vAoc4Lo OV4o5qtietYnMea+W8Hz0gU/LYr9PGuZr6aVpebiRXozWmvHeN0vrXAhKY1hARX3dmxqojy3 HMl0jU97iuqPayzz7bziv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MLJMJo8U7ceWmzvF/ExxTg+CxG0Q6u9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOisYZNBx+oplWw2zGIbWAkqqOHmwtirQchtQ0ebWIqUs4ekWVQxjIXLH5KJlOD1GluKp gUMCib3ocdTbrSVQGigkB/hNOrRXg9BRGAXwwLvdGUySFfmDRjw1If39F3pAZ0yHsRceg22w 3/CNUbqJheCssNKa5tDuYIRsW6TmTLXBLXKWqXZVDqDrsONX7Bo4P+pOxd3pDcRLUYiJ8p3J jRWlJRsmA/P0roFM2VxZVOthTAWn+0UzjhwtxXo5J5prr/Trz2NjDrciFbr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmxbzXpFDQENuIPH9euxLKm5mjvi7VbEC7NarDco7DICdbQoMSyf4Hm YJWiT1KYFJ8l2rSxbD8WbsZ08=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/03/2023 7:53 am, Jan Beulich wrote:
> On 06.03.2023 21:40, Jason Andryuk wrote:
>> hvm_xs_strings.h specifies xenstore entries which can be used to set or
>> override smbios strings. hvmloader has support for reading them, but
>> xl/libxl support is not wired up. This patches adds a new xl.cfg option
>> and libxl support to write the xenstore strings.
>>
>> The xl syntax looks like:
>> smbios=["bios_vendor=Xen Project","system_version=1.0"]
>>
>> The Go binding generation needed extending to support Arrays inside a
>> KeyedUnion, which is what the first patch does. The generated go code
>> builds, but it is otherwise untested.
>>
>> There are also oem strings, oem-1..oem-99, that HVM loader supports.
>> xl parse multiple oem strings like smbios=["oem=A,oem=B"], libxl then
>> iterates over them and assigned to the oem-%d entries. Both xl and
>> libxl check that the 99 string limit isn't exceeded.
>>
>> The rendered man page and html don't have a newline at the end of the
>> new section after patch 2.
>> """
>> battery_device_name=STRING
>> ms_vm_genid="OPTION"
>> """
>>
>> however the txt format is correct:
>> """
>> battery_device_name=STRING
>>
>> ms_vm_genid="OPTION"
>> """
>>
>> It goes away after patch 3 is applied since it adds text about the "oem"
>> option in between the two lines above. I'm at a loss as to why this is
>> happening.
>>
>> v4 is a rebase and resend of v3.
>>
>> Jason Andryuk (3):
>> golang/xenlight: Extend KeyedUnion to support Arrays
>> xl/libxl: Add ability to specify SMBIOS strings
>> xl/libxl: Add OEM string support to smbios
>>
>> docs/man/xl.cfg.5.pod.in | 49 +++++++++++++++++++
>> tools/golang/xenlight/gengotypes.py | 41 +++++++++-------
>> tools/golang/xenlight/helpers.gen.go | 51 ++++++++++++++++++++
>> tools/golang/xenlight/types.gen.go | 28 +++++++++++
>> tools/include/libxl.h | 5 ++
>> tools/libs/light/libxl_dom.c | 33 +++++++++++++
>> tools/libs/light/libxl_types.idl | 27 +++++++++++
>> tools/xl/xl_parse.c | 71 +++++++++++++++++++++++++++-
>> 8 files changed, 288 insertions(+), 17 deletions(-)
> Is this work something that's worth mentioning in CHANGELOG.md?
Yes. Thanks for remembering - I'd forgotten.
~Andrew
|
