[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/xl: rework p9 config parsing
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 21 Mar 2023 10:44:18 +0000
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 21 Mar 2023 10:44:51 +0000
- Ironport-data: A9a23:jjbuFqI+S4uS99LGFE+R3pUlxSXFcZb7ZxGr2PjKsXjdYENS0DBVz WsZW2CBafqNNmKjKox+bIyzphtX7J/Xx4MyTwRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA5QZnPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5KAnpPq acpdQk2Z0DcoMOmnIq/ENRF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHZwIzxrE+ juuE2LRBCM4JoW8zT6+tWOPgcnehi/FAKlPG+jtnhJtqALKnTFCYPEMbnO5ruO+kVWWQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceTCQnz FaTk/v1BDZkt/ueTnf1y1uPhWrsY25PdzZEPHJaC1JfuLEPvb3fkDryTc1iTPWE0+TOEGGv5 BGa8BA63Yg62JtjO7qAwbzXv969jsGXEV9uuFiHBznNAhBRP9D8OdHxgbTPxbMZddvCEAHc1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuKGpxeEdMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QRM8MqK1fZp3k+PyZ8OlwBdmB2yckC1 WqzK57wXR729piLPBLpHrxAgNfHNwg1xH/JRICT8ilLJYG2PSbPIZ9caQPmRrlgvMu5TPD9r o832z2ikE4EDoUTo0D/rOYuELz9BSFmWMus8JAHKIZu4GNOQQkcNhMY+pt5E6QNokifvr2gE q2VMqOA9GfCuA==
- Ironport-hdrordr: A9a23:nsYtvatUijwdarnYtV1TVQIp7skDeNV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpgHIKmnT8fNcyL clU4UWMqyVMbGit7eZ3DWF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Mar 17, 2023 at 12:15:46PM +0100, Juergen Gross wrote:
> Rework the config parsing of a p9 device to use the
> split_string_into_pair() function instead of open coding it.
But that wasn't an open codded version of split_string_into_pair(). Now
if a value contains a '=', everything after it is ignored.
split_string_into_pair() would split the string "foo=bar=void" into just
"foo" and "bar".
As the man page doesn't say that VALUE can't contains '=', this patch
looks like a regression.
I start to think that split_string_into_pair() is broken. I've notice
the same issue when reviewing the "smbios" addition, and did proposed to
"open code" split_string_into_pair(). But maybe that function needs
fixing instead.
Thanks,
--
Anthony PERARD
|
