Re: [PATCH 2/2] tools/xl: rework p9 config parsing

[Juergen Gross <jgross@xxxxxxxx>]

On 21.03.23 11:44, Anthony PERARD wrote:
> On Fri, Mar 17, 2023 at 12:15:46PM +0100, Juergen Gross wrote:
> > Rework the config parsing of a p9 device to use the
> > split_string_into_pair() function instead of open coding it.
> But that wasn't an open codded version of split_string_into_pair(). Now
> if a value contains a '=', everything after it is ignored.
>
> split_string_into_pair() would split the string "foo=bar=void" into just
> "foo" and "bar".
>
> As the man page doesn't say that VALUE can't contains '=', this patch
> looks like a regression.
>
> I start to think that split_string_into_pair() is broken. I've notice
> the same issue when reviewing the "smbios" addition, and did proposed to
> "open code" split_string_into_pair(). But maybe that function needs
> fixing instead.
Yes, I'll add a patch fixing split_string_into_pair().


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature