[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/7] xen/riscv: introduce boot information structure
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Mar 2023 12:17:53 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=znDf5s9/3LltS0fPY5nb1DsJ8gluU+1uUoXM5F/4f4M=; b=hYab4R3C5zde0HMRNDILQjE8h3P1pA8WWRY0tZDhtoKfyfn5B1TMLWoDfQT7dJHCB3rYFeQgEogAQBuzwc94ikntg73Ce/fDro4vtHTrS3D1MuFFYsqeplB8vqM1FnTL7xMF1bXTCtJg/QjvMaM08PT4IM3HjuvC2Tj3iKAvY2707A1PxJ7peiBOIdqEvs9HK8HjlxLmChPE6Q2RxeZVKgGLjlvA2JHMR8Qs0dgflzjUVqlySghtieb01lXL2t1B1oR4L/ajW8fNCjNAOYrScQska/CyybXLpHCOxo7rdeCjx3EM7BBd3KJ3ZxPJUEEZ8mYy7ee3CKbSPFMvfccjDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aQpykAnt+cxFGVajXgYDQJ62IXVcqD6ib9CtTHmLt+a2wzo1dp39QmKEfmLq6icJx8MQrNHzZRGtk99mPxHBvmWIi/SR0soQNoOvEGc7oE0+EwJiXicbPvJxapBpgsossp7g+WeLYQn/9wkyvEMME+3MTTRKHH1HoQJIzsPGKjuK16mkpG8EScU92dCOOm0PQ9BR7DLWa3iCnh310MnCv5FMh3eDPl3PWYacVbS7tiEFpw1hYVHNat5uhhNdbDBIJNyQsMkSMMETzqfvl4K8CPS4ye1cLOppsnbHz1CqcyjBBhE6Tv8ItXhkrUMEJTwmZZsqhSKfLxeNaJAAGD5o5Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Mar 2023 11:18:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.03.2023 15:39, Oleksii Kurochko wrote:
> @@ -50,4 +51,6 @@ void asm_offsets(void)
> OFFSET(CPU_USER_REGS_SEPC, struct cpu_user_regs, sepc);
> OFFSET(CPU_USER_REGS_SSTATUS, struct cpu_user_regs, sstatus);
> OFFSET(CPU_USER_REGS_PREGS, struct cpu_user_regs, pregs);
> + OFFSET(BI_LINKER_START, struct boot_info, linker_start);
> + OFFSET(BI_LOAD_START, struct boot_info, load_start);
> }
May I suggest that you add BLANK(); and a blank line between separate
groups of OFFSET() uses? This may not matter much right now, but it'll
help readability and findability once the file further grows.
Jan
|
