[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v1 1/1] x86/domctl: add gva_to_gfn command


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 21 Mar 2023 13:46:23 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O4wx3K4RP4vqWaw4elVAW8Z1CkxXv1HhIOAo/6EYLeE=; b=obsZf81jFXunMXd1M18O5LPbwK62lxZTDU47nLbXObIBQU6aH8WCil4To50UAkmcaIQfWJF4EHcie/k813/cQ2YvVHQSDT+4NfWQ5i7HZfCwHax3Z3Ily0gd3LKGrHGfA85gA7nGNKo4JoRZuwyV/xQ0O97zZFiJSv31advnEJPtR7uGEsRuukLeFDziShRAV2RAKZRY9O8/8hVCekIrewbzJfVDkPRWMqXvpKN0rEeeTzK6zvBfpPwpBqYdTkCWufWt3k62i7G+MIV70INRP7yXtgGcr8/0fL3tTFlT9/VkLka/oduWDbyblAnzR34LAqYrxUWBHFgtwOSPjFl6JQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VrSBL2fdV7umGmLLqa1G2gQCJQe8vHlUeE6esY7O8cuEPwtoe4Lah2kvZuOSj4yrW/SkULQ+u2P+QWBNp/dC/pL+w/h+6fle1u+WXp18CLHFWnM4W0Az2zyB/M/GHfI01LAduL3kCOIevvVAKsdh+a8CDZC1c1XH3egRiyJYeac2yj/hF6jfrEsN+sKFPapG8NvAtT9CIAqrFn5i5zPjuWePPQDrRz31psx4fAnu1EKPDDAGrFhn3cUkUf8fErRU6xk0VXupZ8t9f6cw2he/fEDI/98YCF2PHMrzTDqY11vkWOdwTHu/Kr5vH2btlFwOhn/95/O2mj0fcvfsEm/YpQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Dmitry Isaykin <isaikin-dmitry@xxxxxxxxx>, Ковалёв Сергей <valor@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 21 Mar 2023 13:46:57 +0000
  • Ironport-data: A9a23:kPkk+aucWpjD7FtueUScU5kA9efnVN1fMUV32f8akzHdYApBsoF/q tZmKW6PPP3fM2umKN4iPomz9x4B6sKGx9IwTwE6/ik9RC8R+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5ASEziFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAXcrZzSdg9+MnJ34cbdXu8hzPcPzM9ZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4C9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqqcw3Q3NngT/DjUYcHSjpcSo0HebVtlWE WcYxi4jkPQ9oRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQoy 1uIktXBFTFp9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbkhvKR81LDK2xg9v6CDz0h TuNqUAWhq4ajM0K0eC3+FHbmSOEt5HPQgMloB/KNkq75wd+fqahZpe0r0LGhd5QIYDcQlSfs Xwsn8mF8PtIHZyLjDaKQugGAPeu/fntDdHHqVtmHp1k/TL9/XemJNpU+Gsnex0vNdsYczj0Z kOVoRlW+JJYIHqta+lwfp61DMMpi6PnELwJS8zpUzaHWbApHCfvwc2kTRf4M7zF+KT0rZwCB A==
  • Ironport-hdrordr: A9a23:KrvbTK8L6ypTjZHif/Juk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21/03/2023 7:28 am, Jan Beulich wrote:
> On 20.03.2023 20:07, Andrew Cooper wrote:
>> On 20/03/2023 4:32 pm, Ковалёв Сергей wrote:
>>> gva_to_gfn command used for fast address translation in LibVMI project.
>>> With such a command it is possible to perform address translation in
>>> single call instead of series of queries to get every page table.
>>>
>>> Thanks to Dmitry Isaykin for involvement.
>>>
>>> Signed-off-by: Sergey Kovalev <valor@xxxxxxx>
>> I fully appreciate why you want this hypercall, and I've said several
>> times that libvmi wants something better than it has, but...
> But is a domctl really the right vehicle? While not strictly intended for
> device models, a dm-op would seem more suitable to me. Considering you
> already brought altp2m into play, it could also be a sub-op of HVMOP_altp2m.

It definitely feels wrong to be using an altp2m op if you're not using
altp2m, and there introspection usecases that don't use altp2m.

dm-op would be the place to put this, if I wasn't pretty sure it would
be modified over time.

As I say - I can see why this might be useful, but pagewalking is more
complicated than the interface presented here.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.