[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/10] tools: add physinfo arch_capabilities handling for Arm
- To: Christian Lindig <christian.lindig@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 22 Mar 2023 07:02:40 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vt6K8YXPVCTU62et5xXQBcb2D3BNDzhTqy4aWhR5wNc=; b=PVsIJwVsamnjcRXRoAynKHb057Hn4fn8h5JVhZuRCDPzEA1IxrImF+xJ1ITUN/QGvFTrHblIG1A5W6oD69oKr8yN+CWBQOXtonJjzAqsWdhDsuVOjd3DR2GsgkiqxLYvL1F1tMy8mpn9Fzx5A+gqt+If1UbkAjXqc0nUw2vdVoK/WiTxuJZuQYmSgrP27O2Jod1wRZ0IWZIT0sKHWTgzzEoRTWQmV0O573g/B0DOrJsouNbz/TYepX5XcHc1Ej5AoX0a55rfGt6iBcBU9gwWtTg6H+aps8kshQLMK79kFOwNCcxABEPAHGzaGxv6n2NmxIYRsL75CyPlD/KA6nyBWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HKlyf6AdzKrn575jhDZ2edw6tZhPHqfASHf/RzkK6bhfxwlbg9BZDGqL7WmZcgoEg0CED9xCowvPFtW6qunrsp/6Am/oUJk/uvOQdqWd9v7+m4l2u/upKecsKBLb13vYhXTxq9PZjuYnAPholdI+FR6v8d4aU/jAssn2x4NH7nl1kjitAilcQUiUF/ubT8aIYxkQ77U0swd0koGsqAXNPAi+paFPTyAa1zdsta8MBUL5RlffVHZEg2DKOOeUdES6zZ1p6EiWyXJz+c9kwuGgOcrw1kOSAQPDdZIG+7cjnj+V8p4luZie0qa1XPv1DQL4RGLEaWLhUHdOuNUBAKEE7A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Edwin Török <edwin.torok@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Mar 2023 07:03:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZWNNJv7KxtCj5PE2Y2ezKy93ynK8DhO2AgALh9IA=
- Thread-topic: [PATCH v3 08/10] tools: add physinfo arch_capabilities handling for Arm
> On 20 Mar 2023, at 11:01, Christian Lindig <christian.lindig@xxxxxxxxx> wrote:
>
>
>
>> On 17 Mar 2023, at 13:19, Luca Fancellu <luca.fancellu@xxxxxxx> wrote:
>>
>>
>> arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag);
>> Store_field(arch_cap_flags, 0, arch_cap_list);
>> Store_field(physinfo, 10, arch_cap_flags);
>> +#elif defined(__aarch64__)
>> + Store_field(physinfo, 10, Val_int(c_physinfo.arch_capabilities));
>> +#else
>> + caml_failwith("Unhandled architecture");
>> +#endif
>>
>
> Is this code overwriting an existing entry that was computed but now isn’t
> used? If so, should the conditional compilation not avoid this?
Hi Christian,
I don’t understand, what entry is being overwritten? If I understood it
correctly, I’m writing the position 10 of physinfo
which is not written before.
Cheers,
Luca
>
> — C
|
