[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] include: don't mention stub headers more than once in a make rule


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Mar 2023 11:59:40 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qk6pneueVWqDtadW3WGirrHvMSJ7bTzjdbhVxSHHs0g=; b=LTQHWR1fNQA6YKE9HG7htKrt2jz4WW8CTt1u22X/nqkinN7J96MiyhW7ehdZjxzX7cBEXog1tpbpbJDAKyuOxQm/8iBMKWU8NZEmjUjk3NL+lZzfDHzrR+bgkAC/NQ1qRK4usGw18Q+4MpgEQ5Q9A0ZJzH/DwRFXwHUzQSFvaHkgx/VR1nwo0axY2I2Rrb4jTjBYx6yxFKE1IP0jxHKW7D8sAO+lFGAf0XBBMqut+hrjxhhh6snWfggPFjTFFn8B8EwzQoiXqCWIQOYTE7tnQEie9lJDPREJseEIRjCfh+5VUBNhRjwrrz+rVdwtyoQiqeV12eUzLi7ML3jhfNdsew==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jk2p7NhYIgUSpRDpEXXPFM/x1qT7UJb21CNqOUGxVse3e7Ksf/3+guOSLkShnQTnHXaZ4mVQqLpHO0AY+ymGJFWxjgJxawJPPMeQPxvKME/qeXvpg4F/SRl0QD9ckK1TJjHw85Lyh2rTq4nmxWizUWlWKUwyDIEeuDxoRTaIVckiph6825WK3AiFi3eJYAVsRajxWhp2Rap49z8IGf7oJxt5Qtf1pihIsJCTUd3poXeOMNAS0EORVaQxO3MG//yQ/ZgZqVoQGg1cG/zImv+HgMsATeL+OCvnkOE8/JdmBg/+3Ct5rblfnPqjpvkyTTWjRgWQRFjqVFdDye0Hxoen5A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 22 Mar 2023 10:59:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

When !GRANT_TABLE and !PV_SHIM headers-n contains grant_table.h twice,
causing make to complain "target '...' given more than once in the same
rule" for the rule generating the stub headers. We don't need duplicate
entries in headers-n anywhere, so zap them (by using $(sort ...)) right
where the final value of the variable is constructed.

Fixes: 6bec713f871f ("include/compat: produce stubs for headers not otherwise 
generated")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -34,7 +34,7 @@ headers-$(CONFIG_TRACEBUFFER) += compat/
 headers-$(CONFIG_XENOPROF) += compat/xenoprof.h
 headers-$(CONFIG_XSM_FLASK) += compat/xsm/flask_op.h
 
-headers-n := $(filter-out $(headers-y),$(headers-n) $(headers-))
+headers-n := $(sort $(filter-out $(headers-y),$(headers-n) $(headers-)))
 
 cppflags-y                := -include public/xen-compat.h 
-DXEN_GENERATING_COMPAT_HEADERS
 cppflags-$(CONFIG_X86)    += -m32



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.