[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/5] tools/hvmloader: remove private offsetof() definition

To: Jan Beulich <jbeulich@xxxxxxxx>
From: Juergen Gross <jgross@xxxxxxxx>
Date: Wed, 22 Mar 2023 13:47:26 +0100
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 22 Mar 2023 12:47:36 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.03.23 13:42, Jan Beulich wrote:

On 22.03.2023 13:08, Juergen Gross wrote:

util.h contains a definition of offsetof(), which isn't needed.


While true, this is also ambiguous in the context of this series: It isn't
"not needed" because common-macros.h has another definition, but it is
actually unused in hvmloader code. So perhaps s/needed/used/?


Fine with me.

Remove it.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>


Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

References:
- [PATCH v4 0/5] tools: use xen-tools/libs.h for common definitions
  - From: Juergen Gross
- [PATCH v4 3/5] tools/hvmloader: remove private offsetof() definition
  - From: Juergen Gross
- Re: [PATCH v4 3/5] tools/hvmloader: remove private offsetof() definition
  - From: Jan Beulich

Prev by Date: Re: [PATCH v4 1/5] tools: add container_of() macro to xen-tools/common-macros.h
Next by Date: Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH
Previous by thread: Re: [PATCH v4 3/5] tools/hvmloader: remove private offsetof() definition
Next by thread: [PATCH v4 4/5] tools/libfsimage: remove private offsetof() definition
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.