[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/5] tools/hvmloader: remove private offsetof() definition


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Mar 2023 13:42:38 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eEOU7cXu/LPxXOjMLbHBitPpfPY/EMUhyfJHlL2VeKc=; b=CavJSP23s0vcsY47NQN4gu40Txqv+273pCidOZvVD+McJycmRv1o5VYyKWVDNu6IMNwIPMgz+ZQzf0uBZyr0DBPPO+38G5pYSyA9tZK3xb7+HIUVAxmsH9B9CC/fQ/h8GS5m/p2P5M+djfhCOGvmIpnaRscc69EPestPgHTz0UCYtTVOnStkf6MnCkrgynbGaSjtuBcEbxDtvy2iP+u4pK7FPP6EUmj9Dy6H3ks6HefWAxi3kKjSS0WCN0ioV4Cf+oEsCSesTAs98nq+6w8wqqYaBag02ytKiL+g3DVWv2KOBp3RL0jwZNqwoVcGfFdYO3CSJJyGtYa7z+wmzZhNgA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DsS58HE+F1g6jHCmgvyNR/ZSkNGvamGOTar/nqD7gPEuxI5G6KmGyqWUkYnRSKA3PYMk4HJZyG1qIAt5WkAkanc30Mp57DelRZHYPMUbDS29VVzxGCx9MwWC9Ynd6rZEq94BezjayZizs4fxVecTATbL9XWYGoA8fd0ceX3UggKVY794GaD3leDadZ3dlBKhv4nh2q8JOWkBHRxQhx/LJNwtIIVoXYzVrQnufNkomE+ufrH9kCknlYsbvPeywFJN2ohdKXhNqm20oMgo9fe0nHywHRkhxxf/KGWv87SREMAdgJSujiWCQU6atYmfMJqLPP/u9GGyljT9TmVmEkSixw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 22 Mar 2023 12:42:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.03.2023 13:08, Juergen Gross wrote:
> util.h contains a definition of offsetof(), which isn't needed.

While true, this is also ambiguous in the context of this series: It isn't
"not needed" because common-macros.h has another definition, but it is
actually unused in hvmloader code. So perhaps s/needed/used/?

> Remove it.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.