[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/arm: domain_build: Check return code of domain_vpl011_init
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 22 Mar 2023 15:22:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS8IdW0ZgVWa9MP1baWDVlOvLAzK6/3o0few2DLWQmo=; b=JNYBS/H6KgOOp5DRf5QtIev1KIKSSetOpEXhst+5LVOVywSLm1hnqHFEwJriQXpwNBKwJNG3go4pb5SV4YdOYAPrjEIA2BzfndjPQ5d0jsxzKWNdYYjKKc2Ib9W2llf4rQRyFZZNwtUsSb46sgMzvMlLPag3Gfg4LNpD9Xk5R+4Wu6J4YOEbae79Xd470qBmjxWkTp+pM8CRBMXZd8QuIW9qsBA4UgfIEUM+Ryt1e0BBYfQ/AAvtW9+58HRICTYtEUNlVPDk56thx3+CekDN4EtE8TPCXjyS51U69y751oxQaBPSGzRaMhm2p8LbstAGPR1tYiKPC/Jih1uhVsRxaQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PoT51Q+zLFCnClejhOSrwdwMCkeZf5eBvrJ+YoANCuypRoIKLbAyOChFRdfRQi/YXM8cahfskmsp1ad73V3rtk3C7pAGjbnd8n1naH3e+7SwydqXNp/lBvhbvGB1AKvF40UWDNC/VuSW9gByZ29oS3j6fLWNB0tFCdr3Q3+1flvs61u4NO0d8zPsn/nl/eIt0dyLeMqG8cXg4PPeMOiPin0qXk0cN5rHTJtLV4Ie0xJM3tV35lJVNvYVQ06NZwhAal7b0Ou5iSOh+aPkdlQnHzlPpynUAue2PkXp8+cimaRS6f7P7rlHkmI/wLGmEWAMVpFQdqWWCloBfpMD1CQimQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 22 Mar 2023 15:22:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZXKlUoZLZ+Or8ukSLI0BaT4Km/K8G6r2A
- Thread-topic: [PATCH 1/2] xen/arm: domain_build: Check return code of domain_vpl011_init
> On 22 Mar 2023, at 10:29, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> We are assigning return code of domain_vpl011_init() to a variable
> without checking it for an error. Fix it.
>
> Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address
> and IRQ number for vPL011")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Hi Michal,
Looks good to me,
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
