[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: vpl011: Fix domain_vpl011_init error path
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 22 Mar 2023 15:31:55 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n/ZDuoIlgmSqrEPggJrZYbxTyjW8pSA/JtkX+2WEkV0=; b=APIdzuYJS77tIigDO7Pesa/5i44IHrC2r4Oq7cVkjtuE5JjPi+HczZHxDPAoBj1lW4GBF/IbbFlEliTj8OZUDXfzASX1qtKr6xl5Df0v5ODskVV5oZYK0ylw+3Rp3IHgLwHYMhzTtsOYAv2iHFB+5GE+JnF8btTxnpeD9uH0ORncGBK8JQRXW++Wf8d32ioocCBZOfQ/MbTR6JddHYVLvt5aLEBZuI+2+eCmVbcW8sLiqTB4jgoENTsuokGXjx0cQhBsko5y7M2nye/TUGCJN3vDqV6cmHoOk5Bj0mtPlvM4OS3BPFjSOlXsVm9ocK8BZ5ihdzMzUeTRzAsOmaUIfQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i31Y3t1KTfar8BzNcsBxyh2bMtRSU6GIbHqCrb6tPE4ubfPnsYiHJcRLTHPWP8exzHpBUWJQa5s0s11Tnn+vXYi2S2VMswvrF4qftYpQXW28L/3JhV9tqYYyAzAPqxdDwr9MG3ORpIc1SlC1CL6FOKPBPZE4Di8kdxvzo76F7yELeLtnuqcJ6cpgiwiVw98qEmi+zIEgcO9kAbkVVelfCzgg5hGVGPZ6iSQw/NL/N+QcnSTg6bVQ4JTOe/lBXoipGz4AsLqMtNYB4pGKUqHEi86rBuJAdT3P3nd4nF/ZrK9SqBOwgtLvT20RU3Z0xyQ5Xu4ICmc+jUor8l1J6XT5sQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 22 Mar 2023 15:32:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZXKlPma7CnH/bnE+l0dOUYhvW568G7X0A
- Thread-topic: [PATCH 2/2] xen/arm: vpl011: Fix domain_vpl011_init error path
> On 22 Mar 2023, at 10:29, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> When vgic_reserve_virq() fails and backend is in domain, we should also
> free the allocated event channel.
>
> When backend is in Xen and call to xzalloc() returns NULL, there is no
> need to call xfree(). This should be done instead on an error path
> from vgic_reserve_virq(). Also, take the opportunity to return -ENOMEM
> instead of -EINVAL when memory allocation fails.
>
> Fixes: 1ee1e4b0d1ff ("xen/arm: Allow vpl011 to be used by DomU")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Also this one looks good to me:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
