[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/5] tools/hvmloader: remove private offsetof() definition
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Mar 2023 11:09:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qYaUDMdrK2XcXMKL8Bzvq2LZH5YaGZ9OgSxajGMg5qU=; b=O8HeSUXhjJdJtV6DfEMjVhVzrYsdjPr4K9Hj8rVrlADp3zyucQ/I+7tPp9MmB7Jc6LgDpQ7dNmQ0saMdXUeZ2mYKvfkRY7JldZdlep0TzX3/6qCsvLqO/2CVNKA3+2DoYphnH4rKH27lQU8tsYbrdCSKBieolTIXe71fxg2+7mjM/f6iUWCPHW6mLzMrJd4qYvZ9KZtGMGKYQVkOTGLYHTQNaIq92W34GITaa3cb2cLGSGJ8QaEbqdSDqWotdqfhtMgzcUzAZ8fgMXdDAS+c/LMvArHhvFrgz2eAlfIZtTMwm8TqKYFcXLETgTcahvjyVCeqbVGFWW2ehoZzwPgr+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtKyuLpAfobRDnzQZwZYCTgfvF+58rWkT+DyFQcnM7ZdqOiPWZt6jBYZ7K7+egTaJ0yQzNuX6E4v6VS+dMs56eir8RjyxX7+G000rdtZEamvuE1Kce3jnveSEXku7BtIl4G/VgMzheBro/4FVXwZH+fCJ/FlKsqyux75swGsihvv53KLEoVoZ3aVD4WlJFq+vH6Q0SwPJ7xClzhU6ZnBswXG/r14696eNpwlL34q7t9QyZNBRRNB7WhEAMgFMpMaGhXvvWXaPDVeeBCa1JU9LR3C810z3fS6Jg94vlVyDPMfsBE2LQ16R+damzakDl4oxaWr+J1eVmJXfLX2W6pDoA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Mar 2023 10:09:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.03.2023 10:08, Juergen Gross wrote:
> util.h contains a definition of offsetof(), which isn't used.
Coming back to my comment on the earlier version: "not used" isn't true,
but the earlier "not needed" also didn't make clear why it was not needed
(misleading me into making the [wrong] suggestion): The macro is used,
just not in hvmloader/ but in files living in libacpi/ and compiled here
(as well as elsewhere).
New suggestion (which I'm happy to apply while committing): "... which
isn't needed, as firmware/include/stddef.h's doesn't really need
overriding". (The same, btw, is true for NULL, so I guess I'll make a
follow-up patch to remove that one as well.)
Jan
|
