Re: [PATCH v5 3/5] tools/hvmloader: remove private offsetof() definition

[Juergen Gross <jgross@xxxxxxxx>]

On 23.03.23 11:09, Jan Beulich wrote:
> On 23.03.2023 10:08, Juergen Gross wrote:
> > util.h contains a definition of offsetof(), which isn't used.
> Coming back to my comment on the earlier version: "not used" isn't true,
> but the earlier "not needed" also didn't make clear why it was not needed
> (misleading me into making the [wrong] suggestion): The macro is used,
> just not in hvmloader/ but in files living in libacpi/ and compiled here
> (as well as elsewhere).
Ah, okay, I only looked in hvmloader for users.

> New suggestion (which I'm happy to apply while committing): "... which
> isn't needed, as firmware/include/stddef.h's doesn't really need
> overriding". (The same, btw, is true for NULL, so I guess I'll make a
> follow-up patch to remove that one as well.)
Fine with me.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature