[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/16] x86/shadow: move OOS functions to their own file
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 23 Mar 2023 17:44:58 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RMBEwq9qlCoSw0Fs+f3+SVNp7uYSx9IKamAdmhll53w=; b=lxlMG+QS1fBYS/9pbqTmes/7SkW+Jylj9QwHMHTSQBSiUG9BrxRoL/WBckwVhVy9ASK6oMzyCdC2qh0bLRrNCvsY963XCXyW1efttGGL+xi2UOjAD618R9Z3b1kC69vvwtx+v6LjCV0nrQl9dL5fZfEVrn/ISXpfJXZ07os5PNUMJWuPK2kNNrTmTESGPwQZb9Fr9nqbgMvwpNqnHK3BcfS7RWQokVBesTYR42w2IsrjvDAIcP/quqmnSQgBnYfv5ATKtamARWrgcr3HWAqZXgZwWTUvkvk3wFm95nc9Kzv+pnMTV5ZyMAIUPcy5T1XUs9L/+24ZC/mInfHURyIDkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DT8tvb6MhEimQ28+zmOOoo+HXSE0TwBUCynry9wSfh2xIrj+duh2BIq9IGPM0K5iF253CyryQdlZpM/qLi/mffvumUeIax1TQtziFeLaUg3SmYQnjnZt04IetuIah7/mcLts/XbtaeeC4XLDx0YRUwew2gCMgSoHlI6zYGkouFdTSWb8bmaqguo4zkc9rR3o44LsZryRVID9cPkSlxMSHvzXO09FlQGI9/CyynvS0eujcT9lZH+P3jQtZYE4LE7ptBjloVkOOEa7sk0NePuqOnseSzuo0ZzQdg/K0ctAKVbCD8rfhibhJYVihbtm0axeKCqa5OSO0aPj2s529XcmUw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 23 Mar 2023 17:45:19 +0000
- Ironport-data: A9a23:iwa+zqwbTmW+RpT/JWp6t+cHxyrEfRIJ4+MujC+fZmUNrF6WrkUCn 2NLWTyCPv2DMWfzLd53Ooq0oRhSuMCHyYRrQVNr/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRlP6sT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWEJy u0fOhksVE/Zh9m4yrWDQO19if12eaEHPKtH0p1h5RfwKK9/BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVlVMuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiANhOROHjpqACbFu7+HMMCz8MRGKHr/CD0mSRctFzL UE/0397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOqM4zbSwn0 BmOhdyBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kOYgnnS99iFOu5i4PzEDSpm jSS9nFh2PMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswaByMMhm4UmxqRGw
- Ironport-hdrordr: A9a23:u3fx2K0dO5gtbRXnTNtl6wqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP+VUssQ4b6LK90cW7L080lqQY3WByB9eftWDd0QOVxepZgrcKrQeAJ8T2zJ856Z td
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/03/2023 3:40 pm, Jan Beulich wrote:
> On 23.03.2023 15:30, Andrew Cooper wrote:
>> On 22/03/2023 9:35 am, Jan Beulich wrote:
>>> + {
>>> + if ( mfn_eq(oos_fixup[idx].smfn[i], smfn)
>>> + && (oos_fixup[idx].off[i] == off) )
>> Given that you mention style in the commit message, it would be nice to
>> move the && onto the previous line.
> Sure, done (and there was a 2nd instance).
There are plenty more. I just stopped reporting them.
I guess if its "just" whitespace fixes (newlines, rearranging of
operands/indents) then that's fine. Everything else can come later, and
there is plenty.
Subject to the SPDX tweak, Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
~Andrew
|
