[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/16] x86/shadow: "monitor table" is a HVM-only concept
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 23 Mar 2023 18:30:03 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Of7156c3zk/YjPA0gfESys8/Np6ygfs47Mi4th/4sZo=; b=AMASLbq2G70/Iot6zST6oj4qvXWpdnFqFp4PwSoq7JUThoE6o66hifn3jHMDRXLRxyPd1QnyvhHwtXgRHYHX/syAqMZ6OOWZZfp8kS1z0UXZmjXt0f/QJJxjuyFTd8rYuTE3qgFlasIX2SOMy5Bo8cyZqF9p44DK94ZHMEATjZdYpE6qcMW4q1MccB23rspx3fpY20RobdGbSuGIzLqUncQkxInmyuIC5UHzDACzVtM2cI579H+LRtj1rZLFXKMA7lCFICJl/6Puo1CH41Ui/i64dCRWGekFshWPsOBbJyxfz6xlu7UKZfUCI5NTP/glrKZMET76eDTn0BsXhLiayQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/Hk82gS0FT5rvB/QeFLb+ryvAJOt6rPA97qubspOgbjCs469F4rwAPCRRZChvP302Xns2rxM06Op0xPBbEBXU4PZakPrJUzd+jkc1jqE0zKE5Rmkx1lm3kYfEZF/0CZGK6Xs5RvaJcsXjDTJ4acWVqMhzDbgWJV7bSZ5+qMFdmc1fZ1a/nMaBb621sAzbhL6zSDFiHQP9eovg0MX1spdEpPTATZpFgH2JXBz3n+WDqCFjVds2EOTY0J+J2htsIpKORzu75M8+LjdyNHmMzvOQhsdkuejl4+Bsjy8Ia7gBgNAhPSy5nBCTG2szztBOP2zuYHkqH+2qlYP6mGAsm18A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>
- Delivery-date: Thu, 23 Mar 2023 18:30:26 +0000
- Ironport-data: A9a23:D3NCPK8RbXbJY/dAmOnRDrUDsH+TJUtcMsCJ2f8bNWPcYEJGY0x3z WUZC2vTPKnZZzHzKYsgaoixpksOvcPcy9ExHAQ/qH08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmPqoQ5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkR9 dMqAhBQSiqBqNucmK2Gabk33cYKeZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpgNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpKROLjqac66LGV7l40Vwc0cguimKPj0neTafYcG nwK5RN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqeS4BZRsI5Z/kuo5bs/7UZtNqEarwgtirHzj1m miOtHJn3+VVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5P2ADwmZX1VqBGwfQ==
- Ironport-hdrordr: A9a23:cbhWj64Kql7Zghr5fQPXwPnXdLJyesId70hD6qkmc20xTiX4rb HUoB1/73WYtN9/YgBGpTntAtj4fZq+z/9ICOsqTNOftWDd0QPCEGgF1/qA/9TOIVydygc379 YHT0ERMqyJMbG4t6nHCcuDf+rIDOPozElgv4fj80s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/03/2023 9:37 am, Jan Beulich wrote:
> It looks like in the combination of aff8bf94ce65 ('x86/shadow: only
> 4-level guest code needs building when !HVM') and 0b841314dace
> ('x86/shadow: sh_{make,destroy}_monitor_table() are "even more" HVM-
> only') I didn't go quite far enough: SH_type_monitor_table is also
> effectively unused when !HVM.
>
> The assertion early in sh_destroy_shadow() can have the type dropped
> altogether: it shouldn't make it here in the first place. Pages of
> this type are freed directly from sh_destroy_monitor_table() only.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
