[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/16] x86/PV: conditionalize arch_set_info_guest()'s call to update_cr3()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 23 Mar 2023 18:34:32 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PRWVyNX0rL+Uq3kmbut4cvfDs0J0oQ/xgbqrvmSpcUA=; b=WpDiKpr49F4WHqb4yoeXorDaAgMbdNhAiIPpdit3Bk+jsAsUd+tnNAux77CR9oZ2cwWjNuTMN/1zy32CKwtQqZCni78z/wHjG+ou4OlKylqOSNEISE5FP0QCPpeBUQ79J1r+KyOJQaqOEftTqbLGgxNSiUNgMKQsRO8NUdANPxvNP75o06R1XAbpXOhcrcYZS7fYYJZ/ddQE57/sfaTyrgC57Vioe5fD/QVdJvm/6xRqVP9j21P6CaDeZhCINeBHimtSZR2HoimH58w9QyFAgZdqfVTNWFF49+iUqjKbmp+NWGsCkf+pInskhnRstz/W/kHjmLO/arGX7HhIaLg5aw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ll6rvBycCVk2eKjufpEQ7HO6KpBbeaIbGLGDp2/CVBu6uf0d7I4DYrBekNiuIcavG2i6ooEDC7coEgg4I4q0m2hK9tIG5pKXqzX+x0vhHokLmMDIbXL6qfJ6mTLh+pvF9uZQB/6CuAPydQhT7L8NWxMhhKI5pbMIzZlen8iAlNDAWsyEn6TroEuAMWdFy/H7lULtPiAmzoFwSDrZ+rtlLQpCx1TefzFKRZt4a70m/XVY/pqnicaFGS1UWR2AWsKC9UASHoXBdQjVRQJDtl5cyfDzEyaDeGMh5e1v2DRi7UvpZMAWs9ObjTYvZmxjIjDAwIE79Ou/RqCezed6efv16g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>
- Delivery-date: Thu, 23 Mar 2023 18:35:04 +0000
- Ironport-data: A9a23:VH1x8am3Bj2QNs2UNGzOenDo5gywJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOXWrXOP2CZmH0KY9/bI/koxxS6MTQztM2SAtr/ytkQSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgQ5gSGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 ds4DjMOaDrEvKWd7ampVvVqutsKPta+aevzulk4pd3YJdAPZMiZBo/svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVU3jOKF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtKTuXoraU00DV/wEQWNCMmTFeRu8W8kxelAt1WO XQRxzoX+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqTTMFSCMV7t+lp5s85i8jVf5mGa+xy9fzQDf5x mjQqDBk3+lJy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:0w3DtKgNMEJG6t5BkYaKFyNbOHBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/03/2023 9:38 am, Jan Beulich wrote:
> sh_update_paging_modes() as its last action already invokes
> sh_update_cr3(). Therefore there is no reason to invoke update_cr3()
> another time immediately after calling paging_update_paging_modes(),
> the more that sh_update_cr3() does not short-circuit the "nothing
> changed" case.
I've finally figured out why "more than" feels like weird grammar. In
this case, "especially as sh_update_cr3() does not..." would be the more
normal expression.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
