[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] x86: Drop struct old_cpu_policy
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 30 Mar 2023 12:08:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v/NcKv16TIQD/oQu6LVYAoa5sDgcXoU6q3RNTFBkg4c=; b=C/nB1ABjk1ZsFihBycm2cMJlTT4RQL80JAdzZmuB3pliZuB+0bjP7fkaDoAuVO/Mf+KuoQffdrm60TfzNUVllaag3DBxov7xyGxC/RsphxaXHKFSo7n4xlbtCYuVi2t/s8sf/TRwLOp937GKSzTXa7WLcmap3zazDnSgzA3D00ft/7CV0usOCfII0q+EJMazB+7Zh5+AOunAhdvQw+A4sk96ADySmyW5b4DJzPV3mfLx7/ktuPDHCzedzGrX9Y1gFjL5FLWNajYYAhZFYbQT4inowgcAnEz09m6eEsQ7drdSeoNG9KnB0XqRgJT23WqPF2l66gytSzKLRydyQ3Isgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bzdSW5jFU4HDicnU0GHiyxZEqTgaHZ2SMuEKpZbYUdP2Th1MoVXYdxCA3az+2Mw4HAZ0V28FHfXRF7DwbzND5okDYndW9zGNg40p7NMJQuwpFl+SiX7NBmzhkQzEi59zkUMIUBnTr+0WMRoZtRBw4DzMMrRySiQbAit0nbAZujVNONDaLrW+OH8tj2A1lpPIczXUn0buaveHYwpnCP0IEKdzNjWvF5WwoEO5p3+Mo44nbwXu9/htVdRANRl2Lg2tbxWm1CHAljtVjxeQ/NJaIxdWgEag8FaDGWHuWOWUQGScKaQquQ8wZg/MBDF+u0cgfPXRFHL16MIuMORbhhG4+Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 30 Mar 2023 10:08:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.03.2023 22:51, Andrew Cooper wrote:
> --- a/tools/libs/guest/xg_cpuid_x86.c
> +++ b/tools/libs/guest/xg_cpuid_x86.c
> @@ -868,9 +868,7 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch,
> xc_cpu_policy_t *host,
> xc_cpu_policy_t *guest)
> {
> struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS;
> - struct old_cpu_policy h = { &host->policy, &host->policy };
> - struct old_cpu_policy g = { &guest->policy, &guest->policy };
> - int rc = x86_cpu_policies_are_compatible(&h, &g, &err);
> + int rc = x86_cpu_policies_are_compatible(&host->policy, &host->policy,
> &err);
One of the two surely wants to be &guest->policy?
Jan
|
