[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] x86: Drop struct old_cpu_policy
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 30 Mar 2023 12:57:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HNtT79M0wU15ghgmZEdph8dNuTHCW12AL1Ql8JAOlFw=; b=Cda4RFMIxX1166EPdLP7PpvK61ltXNinXZLAdgUtdGqDc+4gBlK7pqZYgeDoL5dxhjaR3HW7iL3GJx7CxJv/b5ttM4XUSZGzWwJK9jTLQQ5cvXBY4v/uR7WNuwPxT1jTa/NhfvexUdVylc94TfNSh9aTeB6uxrz9elbzSe5FfrmEeTv2Iqcpupn47j5ahBYg6ZsdE8jorMdl84oMmOb4TKZK2mSg5MecqKeayRxTEI+++4/K2oPplfWZVngrmOMGjSW8wRQltsw9Im+e4nH2cmKv+UMc8UEVQ530Bpnt5V2HItA6QDBaR0zyykE61PieiwL7wA6GqVIh6HZAuU65qQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gm6URKUKxQgvjZN8r+6Awcfff7+Oggk3eI2FbWcMcaMI90HxaPKLKp5XX6yVawweReLg+ToEbeyfmLTo4EmAGE33KK4kvBf2k5u4idT/L8M45LfHF+WUuPuWAGBkUPWcCf5aMBtFg/qemySLQt6pqQD5dKryeuXzxhbxwAFaHi38gLmMQzeWdFeMABXlDho4wmn7ROkMWWMqMdmtZ5C3ZaFKWm8KvIRXXdOZuEHuD7m4vv59TdWqMjlEgzr8cT/KI1JDBCit/yGsNfO0LqIkKNr+BVmXzy+OhqTGUgc0oA3ydC7uuZ9BYGzpHQM8m7W9lf0jBmWJAwtMvswP+v0nuw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 30 Mar 2023 11:58:21 +0000
- Ironport-data: A9a23:LZspZ61Ix77b6uX70PbD5fFwkn2cJEfYwER7XKvMYLTBsI5bp2YEn GJOUT/QOf/fYzH8f4slaIWwo0sG78OAztA1G1BopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gdlPagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAHNpq vY1MT83Nx2cgNCE/+OpbLlTv5F2RCXrFNt3VnBI6xj8Vapja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxovy6PkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHugBtNOROPpnhJsqHKS4CsBMjpGb3e+vsf6pEH9QtRTB lNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4P5YnlqYRr0hbXFI4/Tuiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAuDA3Md4owF6lc2S8
- Ironport-hdrordr: A9a23:W3NtraHcBVuIDodypLqEGMeALOsnbusQ8zAXPiBKJCC9E/bo8/ xG+c5w6faaslkssR0b9+xoW5PwJE80l6QFgrX5VI3KNGXbUQ2TTb2KhbGI/9SKIVydygcy78 ddmtNFebrN5VgRt7eH3OG7eexQv+VuJsqT9JnjJ3QGd3AaV0l5hT0JbDpyiidNNXN77ZxSLu vk2uN34wCOVF4wdcqBCnwMT4H41qD2fMKPW29/O/Y/gjP+9g+V1A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30/03/2023 11:08 am, Jan Beulich wrote:
> On 29.03.2023 22:51, Andrew Cooper wrote:
>> --- a/tools/libs/guest/xg_cpuid_x86.c
>> +++ b/tools/libs/guest/xg_cpuid_x86.c
>> @@ -868,9 +868,7 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch,
>> xc_cpu_policy_t *host,
>> xc_cpu_policy_t *guest)
>> {
>> struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS;
>> - struct old_cpu_policy h = { &host->policy, &host->policy };
>> - struct old_cpu_policy g = { &guest->policy, &guest->policy };
>> - int rc = x86_cpu_policies_are_compatible(&h, &g, &err);
>> + int rc = x86_cpu_policies_are_compatible(&host->policy, &host->policy,
>> &err);
> One of the two surely wants to be &guest->policy?
Ah, yes it does. The second, specifically.
(One of the problems of having an API that's not used by anything
interesting yet.)
~Andrew
|
