Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id

[Viresh Kumar <viresh.kumar@xxxxxxxxxx>]

On 05-04-23, 11:36, Oleksandr Tyshchenko wrote:
> Also a NIT, is this example "like "virtio,device26" for file system device"
> precise?

No :(

I will send the patch again later, this is how it looks now. I have
also updated the documentation to contain the hexadecimal format for
N.

Author: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Date:   Wed Apr 5 05:36:19 2023 +0530

    docs: Allow generic virtio device types to contain device-id

    For generic virtio devices, where we don't need to add compatible or
    other special DT properties, the type field is set to "virtio,device".

    But this misses the case where the user sets the type with a valid
    virtio device id as well, like "virtio,device1a" for file system device.
    The complete list of virtio device ids is mentioned here:

    
https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-2160005

    Update documentation to support that as well.

    Fixes: dd54ea500be8 ("docs: add documentation for generic virtio devices")
    Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
    Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
---
 docs/man/xl.cfg.5.pod.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 10f37990be57..938aea22c798 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1608,8 +1608,10 @@ example, "type=virtio,device22" for the I2C device, 
whose device-tree binding is

 
L<https://www.kernel.org/doc/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml>

-For generic virtio devices, where we don't need to set special or compatible
-properties in the Device Tree, the type field must be set to "virtio,device".
+For other generic virtio devices, where we don't need to set special or
+compatible properties in the Device Tree, the type field must be set to
+"virtio,device" or "virtio,device<N>", where "N" is the virtio device id in
+hexadecimal format.

 =item B<transport=STRING>

-- 
viresh