[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 5 Apr 2023 11:15:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e++isSxOgl7MWiuKsHDzIFCAkVOM4/Smlnr77qRqEsU=; b=Dp9Xs+vjTb6aobqXj1w3J1PKBsRhsCo4c2l5ygtBCJnnAH34myInPHAfk/EDhbO9+1PHhFwgQQ/0O7NR6qog0KBD4tKrNeXSfc6qdsFsl7yT/+pPMiLQ36dnH0syHiCstGXHmDuLKn8PpH0Lt4nil0440NtQ98qOv6Abgu6eWfRpDFsKImFGex4xJRaAdWB9YYbjp3bAXjJOzzW8o4c9EbXYynK3nfrDYZ3a0lLbe8VIulzltJMy2yZZip5PUafKB9KRHOw6dtASn2Ls2ot3blNR2CoZVfdm8JnSeiiqbDl8Em24FsC6gFkFIoOQfAEL5GFVpkbDl8Wo0b68l4MWLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+jaEhnggllRYjqTkpwjysVVVgWFYTGz9lzM5nBjrVMB9UystPgajJFU+uYsPPQdxLs/ndXUOLdb2pZ52y9G55PW6JbTh8VuMHFyzt8W7ak5Mo/AIgdS0OyMDtiqq0Op6qd24U2yEP08YvS80rxQmnsR/aVmfQnIqZaqdJuXwn2GoCr/IyiofILZwcQKXLLqLMpWN9eb0M0yl+aYlzMNDqloe9JzAt4fEb9CgmvfOXTucSION6hIJn2fzvpbKy2ReHCJXLSDOaztWjwQwOUxmYoQzUs0djmzADw9Le9hm2N/va6db5BNUkxpigYCh/jDVcYohx8wASZ315XrXa5J2Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, stratos-dev@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxx, Alex Bennée <alex.bennee@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Erik Schilling <erik.schilling@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- Delivery-date: Wed, 05 Apr 2023 09:15:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.04.2023 10:51, Viresh Kumar wrote:
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1608,8 +1608,10 @@ example, "type=virtio,device22" for the I2C device,
> whose device-tree binding is
>
>
> L<https://www.kernel.org/doc/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml>
>
> -For generic virtio devices, where we don't need to set special or compatible
> -properties in the Device Tree, the type field must be set to "virtio,device".
> +For other generic virtio devices, where we don't need to set special or
> +compatible properties in the Device Tree, the type field must be set to
> +"virtio,device" or "virtio,device<N>", where "N" is the virtio device id in
> +hexadecimal format.
Are "virtio,device0x1a" or "virtio,device1A" valid, too? If so, all is fine,
but if not, constraints on the hex representation may want mentioning.
Jan
|
