Re: [PATCH V2 1/2] docs: Allow generic virtio device types to contain device-id

[Viresh Kumar <viresh.kumar@xxxxxxxxxx>]

On 05-04-23, 11:15, Jan Beulich wrote:
> On 05.04.2023 10:51, Viresh Kumar wrote:
> > --- a/docs/man/xl.cfg.5.pod.in
> > +++ b/docs/man/xl.cfg.5.pod.in
> > @@ -1608,8 +1608,10 @@ example, "type=virtio,device22" for the I2C device, 
> > whose device-tree binding is
> > 
> >  
> > L<https://www.kernel.org/doc/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml>
> > 
> > -For generic virtio devices, where we don't need to set special or 
> > compatible
> > -properties in the Device Tree, the type field must be set to 
> > "virtio,device".
> > +For other generic virtio devices, where we don't need to set special or
> > +compatible properties in the Device Tree, the type field must be set to
> > +"virtio,device" or "virtio,device<N>", where "N" is the virtio device id in
> > +hexadecimal format.
> 
> Are "virtio,device0x1a" or "virtio,device1A" valid, too? If so, all is fine,
> but if not, constraints on the hex representation may want mentioning.

>From [1], both above are invalid. Updated doc as:

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 10f37990be57..24ac92718288 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1608,8 +1608,11 @@ example, "type=virtio,device22" for the I2C device, 
whose device-tree binding is

 
L<https://www.kernel.org/doc/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml>

-For generic virtio devices, where we don't need to set special or compatible
-properties in the Device Tree, the type field must be set to "virtio,device".
+For other generic virtio devices, where we don't need to set special or
+compatible properties in the Device Tree, the type field must be set to
+"virtio,device" or "virtio,device<N>", where "N" is the virtio device id in
+hexadecimal format, without the "0x" prefix and all in lower case, like
+"virtio,device1a" for the file system device.

-- 
viresh

[1] 
https://www.kernel.org/doc/Documentation/devicetree/bindings/virtio/virtio-device.yaml