[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree()
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 13 Apr 2023 11:45:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yBE32qRAmtmPbFr0kHVShrV/37fYMBBmHh6EfBSAWCA=; b=OdtewoJGY/wUSlJ7ePeAf+dEvl0c3iRYJUmcfDcVq9fNXTvEvANuKKDl1wAg4RWS+CdQql3G1DawhpSOpk+xhnbctSiBSo+LEqlq/hauf2JOuwwDgIsjmOg9cO+nWuSnHsaqgXL2oVrGOu8MvOrkOi7yX1fWgn9K/xWls2/MDKEs9XtsDmGRVR+dS1wkFjZXgRbgX4x2526F47NpGzbqpKTNwRCnynJNMqUVipTTfCa5jQ8ED63TGrTYGXNJpQMIzLBwu6lnJ+vxO8Go11B5Jq/DJq739J+8w9sb1xwpFdKsoSNmyONoGV0bF9CyUe+b6S1Aq22HadlYpZn9I3o0sw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrAc0zm+IydeOP9bEwZoAMbbOGokSPSy+fMqeGJToExmQbpzxgzhPZKL8EJEtw3xqA3XzmIdUF8f9A+xnZSihZD7k2qE2EW+WSL/ea34IQDvRmNS81WgxomopV8ebOSQ/GWuZaGs7DHslBrsDKpBbX+jQT2QUNdWUbx2Ar8XcJrFSc6SLRk1Wd1fqReuqNXLKsHQLLz/r3n97GJ1fj+1te6hgu03Wz6nnMyhw8+WeUXUJHEt297g/7/66LKaOQCb8ht2mrzjE71m5DojCtCq6/v9dIemfH++/2Gzs9yT446OU2lbwsPnLy9uP9aWasfiTUvLaJPR6BTsHuGPpCSqPg==
- Cc: <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 13 Apr 2023 09:46:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Vikram,
On 11/04/2023 21:16, Vikram Garhwal wrote:
>
>
> Following changes are done to __unflatten_device_tree():
> 1. __unflatten_device_tree() is renamed to unflatten_device_tree().
> 2. Remove static function type.
I think there was no need to touch this function in patch 1 if you are
modifying it here
additionally in a separate patch.
> 3. Add handling of memory allocation. This will be useful in dynamic node
> programming when we unflatten the dt during runtime memory allocation
> can fail.
Didn't we say that checking if the memory allocation failed or not should be
done
as a separate patch (i.e. a prerequisite to your series) as part of hardening?
In any case (depending on the maintainers vote), the change itself looks ok, so:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
