[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree()
Hi, On 13/04/2023 10:45, Michal Orzel wrote: On 11/04/2023 21:16, Vikram Garhwal wrote:Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove static function type.I think there was no need to touch this function in patch 1 if you are modifying it here additionally in a separate patch.3. Add handling of memory allocation. This will be useful in dynamic node programming when we unflatten the dt during runtime memory allocation can fail.Didn't we say that checking if the memory allocation failed or not should be done as a separate patch (i.e. a prerequisite to your series) as part of hardening? In any case (depending on the maintainers vote), the change itself looks ok, so: Yes it should be separate because this is something we may want to consider to backport. Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |