[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target()
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 13 Apr 2023 15:11:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TqkGxVz3dOyXztzEvg0vAz1bCZKFuJHjXDqMEbM0hmg=; b=iDGUKblwiUMmNyed67Y1WqLR0xolo81hyjTGtd1rkYZyXN55VNzKoL0DmOI7CXDTosrYzesuIq4jp5uB4NCxxW8KWmNBihvVHXavbp5ePs8LzrL/LGr+3npTnR1eUj81vwg8Ivv1o6UdbEaea2ssrPDKUSlwxPW6MKxZrcRvhdqCK0e02Tyx7O7IcM0BQW0wDWOfRQUeCCnIRx9tmVG3NkTh3umWPUF8kbI64RX40J6bJVfn8xupOv7oP0diNJ1aJsTwu05z43lC+TvOxwsmnkfMLt36s3ZTuqMY8wV08jy2nBSLeG0zPI8Z3qJJCFsU/x7TXqCQEid9EtUoPsmvSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzzymER0toW5nB1v0r0f2DToC/RXaZF4U7IwogO2bnKAwVWktI2PsFALZNF0lakDL1f2egZY3hMuCIl6391JkXXhnEj+KTAhqktTySXC9ykUZpdAOlfrfu6ktlTqRiOhlmVaAmq9MFq++bpKM+30c5hki+l2xdH4WrhNGA2O3n1o4N5d/mOzIZVN7Zz3dCAOvFB3G2u6Tv2Cjere2TPUzhRx8qvsI1wTgzTq8RTnJltCPg2YBPG6hbTdsEXzNNhDXOKMjZWPfE+YoZmKkZ78F2WptIthHxuyBbGhCwSLvmDQuKs91d9fBCspSr8Wh6agtqkFyicA60oeN8AEinCoiw==
- Cc: <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Vikram Garhwal <fnu.vikram@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 13 Apr 2023 13:12:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Vikram,
On 11/04/2023 21:16, Vikram Garhwal wrote:
>
>
> Rename overlay_get_target() to fdt_overlay_target_offset() and remove static
> function type.
>
> This is done to get the target path for the overlay nodes which is very useful
> in many cases. For example, Xen hypervisor needs it when applying overlays
> because Xen needs to do further processing of the overlay nodes, e.g. mapping
> of
> resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc.
>
> Signed-off-by: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
> Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xxxxxxxxxx>
> Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> Origin: https://github.com/dgibson/dtc 45f3d1a095dd
Wouldn't it be better to point to the main dtc repository under kernel.org
rather than github?
Origin: git://git.kernel.org/pub/scm/utils/dtc/dtc.git 45f3d1a095dd
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
In any case:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
