[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target()
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Fri, 14 Apr 2023 10:54:21 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PhD2gGUs0psgEuiecZN5i/3qHZ0Elom1MVvlI/TlWIU=; b=FiPJ+vhy4d3vAnJInwIkrNQsuD9fVDnkB9mhTmLpX1PM29nV6AqOEXVaRFQ+fpJ9otuYuyZ2EnMtVVubQuBIq4uwCJ6EbAWoyhu0mM6x6BWiz1OGG5IFijlRwxR3hupuwXgUHy9+Hb3w2bq4NBwsTS71rFcRZ7pu7iSlZbZ7VtLiQgkn2CEzWksYmfAEiiFkJRfkgJ2EmRW5w7hi7zjb9AHjzwQteRl0O9Z4yi6KZ6kK4TevL8oiTxZDpo67Mbwx5N+F/crY7BAfk9tNd1yA5jATPfEuc2BlB7jUMVuxk4oTO7ONWtZx0AC0kTpc3DvpV5h775E52iC78wpE/0LcUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wd0p5OaEyMrCDZAHixCs9kT3OPLKs/tVMjP6BJ91nJLOLMRZMlGN2g4fhawEQiVQp9BR7C9YlJDOmmVkhUIlQVdHJa2cK7AdZzM0mKJl51S8sZsOh0MlL6h8w6d2CZ2iNM/sdLlVMHsdfQhsh688bjXr4kQP1KKDY4TmnlA7knjJmr+O+L51GjvZF5Fk6T8c+uEajW2LvbBlbd+KQa5/uUIC9bjwnnJXkE803ImMK6zs4jgG5yNWZX0VXO1geUOX+xV9fDJ4GfuN2O4xuI9Jyk+4eg9NnfOCac3ORcet0NEwSrvZ1SeJ7bQl7Jh7bodTYJqlDkvlJ2ubMehKPGodgQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: sstabellini@xxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Vikram Garhwal <fnu.vikram@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 14 Apr 2023 17:54:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
On 4/13/23 6:11 AM, Michal Orzel wrote:
Hi Vikram,
On 11/04/2023 21:16, Vikram Garhwal wrote:
Rename overlay_get_target() to fdt_overlay_target_offset() and remove static
function type.
This is done to get the target path for the overlay nodes which is very useful
in many cases. For example, Xen hypervisor needs it when applying overlays
because Xen needs to do further processing of the overlay nodes, e.g. mapping of
resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc.
Signed-off-by: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xxxxxxxxxx>
Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
Origin: https://github.com/dgibson/dtc 45f3d1a095dd
Wouldn't it be better to point to the main dtc repository under kernel.org
rather than github?
Origin: git://git.kernel.org/pub/scm/utils/dtc/dtc.git 45f3d1a095dd
Okay, i will change it in next version. Is there any guidelines/note for
this preference? Will be helpful to me in future series.
Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
In any case:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks you!
~Michal
|
